summaryrefslogtreecommitdiff
path: root/testing/tools
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2015-03-25 13:56:20 -0700
committerTom Sepez <tsepez@chromium.org>2015-03-25 13:56:20 -0700
commit9b5ec50f2c7939fca543aabee029df59f3f7b1a2 (patch)
treee8c7d35d23d4e9d08520447d1717a83ec5d5ba9a /testing/tools
parent497d864a6eb35ea38f0a6bbd39a62d34a2ad213c (diff)
downloadpdfium-9b5ec50f2c7939fca543aabee029df59f3f7b1a2.tar.xz
Create per-platform pdfium test suppression files.
This is required now that we have win/mac bots, which may produce different outputs. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1031203003
Diffstat (limited to 'testing/tools')
-rwxr-xr-xtesting/tools/run_corpus_tests.py32
1 files changed, 28 insertions, 4 deletions
diff --git a/testing/tools/run_corpus_tests.py b/testing/tools/run_corpus_tests.py
index 05be76ef37..2f5c413f61 100755
--- a/testing/tools/run_corpus_tests.py
+++ b/testing/tools/run_corpus_tests.py
@@ -15,6 +15,12 @@ import sys
# x_path - "path/to/a/b/c/x.ext"
# c_dir - "path/to/a/b/c"
+def extract_suppressions(filename):
+ with open(filename) as f:
+ suppressions = [y for y in [
+ x.split('#')[0].strip() for x in f.readlines()] if y]
+ return suppressions
+
def test_one_file(input_filename, source_dir, working_dir,
pdfium_test_path, pdfium_diff_path):
input_root, _ = os.path.splitext(input_filename)
@@ -45,6 +51,16 @@ def test_one_file(input_filename, source_dir, working_dir,
return True
def main():
+ if sys.platform.startswith('linux'):
+ os_name = 'linux'
+ elif sys.platform.startswith('win'):
+ os_name = 'win'
+ elif sys.platform.startswith('darwin'):
+ os_name = 'mac'
+ else:
+ print 'Confused, can not determine OS, aborting.'
+ return 1
+
parser = optparse.OptionParser()
parser.add_option('--build-dir', default=os.path.join('out', 'Debug'),
help='relative path from the base source directory')
@@ -76,7 +92,7 @@ def main():
# Compiled binaries are found under the build path.
pdfium_test_path = os.path.join(build_dir, 'pdfium_test')
pdfium_diff_path = os.path.join(build_dir, 'pdfium_diff')
- if sys.platform.startswith('win'):
+ if os_name == 'win':
pdfium_test_path = pdfium_test_path + '.exe'
pdfium_diff_path = pdfium_diff_path + '.exe'
# TODO(tsepez): Mac may require special handling here.
@@ -86,9 +102,12 @@ def main():
if not os.path.exists(working_dir):
os.makedirs(working_dir)
- with open(os.path.join(testing_dir, 'SUPPRESSIONS')) as f:
- suppression_list = [y for y in [
- x.split('#')[0].strip() for x in f.readlines()] if y]
+ suppression_list = extract_suppressions(
+ os.path.join(testing_dir, 'SUPPRESSIONS'))
+
+ platform_suppression_filename = 'SUPPRESSIONS_%s' % os_name
+ platform_suppression_list = extract_suppressions(
+ os.path.join(testing_dir, platform_suppression_filename))
# test files are under .../pdfium/testing/corpus.
failures = []
@@ -102,6 +121,11 @@ def main():
if input_filename in suppression_list:
print "Not running %s, found in SUPPRESSIONS file" % input_filename
continue
+ if input_filename in platform_suppression_list:
+ print ("Not running %s, found in %s file" %
+ (input_filename, platform_suppression_filename))
+ continue
+
if not test_one_file(input_filename, source_dir, working_dir,
pdfium_test_path, pdfium_diff_path):
failures.append(input_path)