summaryrefslogtreecommitdiff
path: root/testing
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-05-01 17:46:34 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-05-01 17:46:34 +0000
commit3f3c39d04fd68d8ce11f52baa3acae8e0522a2c4 (patch)
tree6126bc07b3e212f758dfa4e13462fb7bfaa6d97f /testing
parentfe06d5109cd575c1e53b9b1cc3cc4ec3c5d7364f (diff)
downloadpdfium-3f3c39d04fd68d8ce11f52baa3acae8e0522a2c4.tar.xz
Check for NULL XFA context even when XFA
Use strict typing for FPDF_Page to ensure we don't fall into code that expects the other page type when continuing from null context case. Change-Id: I7f028ef3e3d733f5557620030a87e22997da00d5 Reviewed-on: https://pdfium-review.googlesource.com/31770 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'testing')
-rw-r--r--testing/xfa_js_embedder_test.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/testing/xfa_js_embedder_test.cpp b/testing/xfa_js_embedder_test.cpp
index 375497f9ea..fe54621a2b 100644
--- a/testing/xfa_js_embedder_test.cpp
+++ b/testing/xfa_js_embedder_test.cpp
@@ -45,7 +45,13 @@ void XFAJSEmbedderTest::TearDown() {
CXFA_Document* XFAJSEmbedderTest::GetXFADocument() {
auto* pDoc = CPDFDocumentFromFPDFDocument(document());
+ if (!pDoc)
+ return nullptr;
+
auto* pContext = static_cast<CPDFXFA_Context*>(pDoc->GetExtension());
+ if (!pContext)
+ return nullptr;
+
return pContext->GetXFADoc()->GetXFADoc();
}