summaryrefslogtreecommitdiff
path: root/testing
diff options
context:
space:
mode:
authorRyan Harrison <rharrison@chromium.org>2018-06-04 20:22:08 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-06-04 20:22:08 +0000
commit80c6ab7b99bcbd7b940f78dc0cac52c30249f59c (patch)
tree0e65dfe95df518322656ecf5fab5432b1b6ba18f /testing
parent36aae4fc09a353e01738bf0bbc302a21ba21ed07 (diff)
downloadpdfium-80c6ab7b99bcbd7b940f78dc0cac52c30249f59c.tar.xz
Convert (void) to static_cast<void> in C++ codechromium/3450
Converting instances of old C-style void casts to suppress return values to use C++ style static cases. There are a few examples of (void) that remain, since they are in C code, and the third_party/ instances are not touched at all. Change-Id: I72b3fc0e1d713db669b76135e03d1cf87873a2fe Reviewed-on: https://pdfium-review.googlesource.com/33790 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'testing')
-rw-r--r--testing/embedder_test.cpp10
-rw-r--r--testing/test_support.cpp6
2 files changed, 8 insertions, 8 deletions
diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp
index 03eebe3abc..aaea965cf0 100644
--- a/testing/embedder_test.cpp
+++ b/testing/embedder_test.cpp
@@ -220,7 +220,7 @@ bool EmbedderTest::OpenDocumentHelper(const char* password,
FPDF_LoadXFA(*document);
#endif // PDF_ENABLE_XFA
- (void)FPDF_GetDocPermissions(*document);
+ static_cast<void>(FPDF_GetDocPermissions(*document));
return true;
}
@@ -262,16 +262,16 @@ void EmbedderTest::DoOpenActions() {
int EmbedderTest::GetFirstPageNum() {
int first_page = FPDFAvail_GetFirstPageNum(document_);
- (void)FPDFAvail_IsPageAvail(avail_, first_page,
- fake_file_access_->GetDownloadHints());
+ static_cast<void>(FPDFAvail_IsPageAvail(
+ avail_, first_page, fake_file_access_->GetDownloadHints()));
return first_page;
}
int EmbedderTest::GetPageCount() {
int page_count = FPDF_GetPageCount(document_);
for (int i = 0; i < page_count; ++i)
- (void)FPDFAvail_IsPageAvail(avail_, i,
- fake_file_access_->GetDownloadHints());
+ static_cast<void>(FPDFAvail_IsPageAvail(
+ avail_, i, fake_file_access_->GetDownloadHints()));
return page_count;
}
diff --git a/testing/test_support.cpp b/testing/test_support.cpp
index 2b6f436c32..16ae5b28b9 100644
--- a/testing/test_support.cpp
+++ b/testing/test_support.cpp
@@ -84,19 +84,19 @@ std::unique_ptr<char, pdfium::FreeDeleter> GetFileContents(const char* filename,
fprintf(stderr, "Failed to open: %s\n", filename);
return nullptr;
}
- (void)fseek(file, 0, SEEK_END);
+ static_cast<void>(fseek(file, 0, SEEK_END));
size_t file_length = ftell(file);
if (!file_length) {
return nullptr;
}
- (void)fseek(file, 0, SEEK_SET);
+ static_cast<void>(fseek(file, 0, SEEK_SET));
std::unique_ptr<char, pdfium::FreeDeleter> buffer(
static_cast<char*>(malloc(file_length)));
if (!buffer) {
return nullptr;
}
size_t bytes_read = fread(buffer.get(), 1, file_length, file);
- (void)fclose(file);
+ static_cast<void>(fclose(file));
if (bytes_read != file_length) {
fprintf(stderr, "Failed to read: %s\n", filename);
return nullptr;