summaryrefslogtreecommitdiff
path: root/testing
diff options
context:
space:
mode:
authorRyan Harrison <rharrison@chromium.org>2018-05-10 18:27:25 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-05-10 18:27:25 +0000
commit80302c77a854e3252bb4c1dc6f09ea3097536092 (patch)
treeeda3dd1fb75d56f4fc561c133604e01fc85390cd /testing
parent3d1ab2d09ab96a6393c0612d9c4153d10d5028ce (diff)
downloadpdfium-80302c77a854e3252bb4c1dc6f09ea3097536092.tar.xz
Use test_dir instead of 'pdfium' for source type
The source type value Gold results is just a logical grouping label. Having a different value for each type will allow the Gold web UI to have a set of labels at the top that allows you to easily switch between specific test tool results. Currently the test scripts are using the test directories 'corpus', 'javascript', and 'pixel', which seem like reasonable labels. BUG=pdfium:1073 Change-Id: I893a1afeb3b87ffb84948c18ae3052b2dd6216ea Reviewed-on: https://pdfium-review.googlesource.com/32350 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'testing')
-rw-r--r--testing/tools/test_runner.py7
1 files changed, 6 insertions, 1 deletions
diff --git a/testing/tools/test_runner.py b/testing/tools/test_runner.py
index 5acda86f54..3fa1c79e04 100644
--- a/testing/tools/test_runner.py
+++ b/testing/tools/test_runner.py
@@ -37,7 +37,12 @@ def TestOneFileParallel(this, test_case):
class TestRunner:
def __init__(self, dirname):
+ # Currently the only used directories are corpus, javascript, and pixel,
+ # which all correspond directly to the type for the test being run. In the
+ # future if there are tests that don't have this clean correspondence, then
+ # an argument for the type will need to be added.
self.test_dir = dirname
+ self.test_type = dirname
self.enforce_expected_images = False
self.oneshot_renderer = False
@@ -272,7 +277,7 @@ class TestRunner:
# Collect Gold results if an output directory was named.
self.gold_results = None
if self.options.gold_output_dir:
- self.gold_results = gold.GoldResults('pdfium',
+ self.gold_results = gold.GoldResults(self.test_type,
self.options.gold_output_dir,
self.options.gold_properties,
self.options.gold_key,