summaryrefslogtreecommitdiff
path: root/testing
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2018-02-13 21:51:23 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-02-13 21:51:23 +0000
commit815f5eba63db351b6b9b53ec6ad49890802f7fa1 (patch)
tree25d2b667aaa5aa18515f165c7767caf2421c76fe /testing
parent56f7117d3fd5799d7c1d13a9c3723e67f508d553 (diff)
downloadpdfium-815f5eba63db351b6b9b53ec6ad49890802f7fa1.tar.xz
Remove old version of InitializeV8ForPDFium().
Change-Id: I5dbf1c78cf794eff817de9f5831b1fb5b49c84ab Reviewed-on: https://pdfium-review.googlesource.com/26491 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'testing')
-rw-r--r--testing/test_support.cpp23
-rw-r--r--testing/test_support.h11
2 files changed, 0 insertions, 34 deletions
diff --git a/testing/test_support.cpp b/testing/test_support.cpp
index af7f3d02ad..2b6f436c32 100644
--- a/testing/test_support.cpp
+++ b/testing/test_support.cpp
@@ -194,34 +194,11 @@ std::unique_ptr<v8::Platform> InitializeV8ForPDFiumWithStartupData(
}
return platform;
}
-
-bool InitializeV8ForPDFium(const std::string& exe_path,
- const std::string& bin_dir,
- v8::StartupData* natives_blob,
- v8::StartupData* snapshot_blob,
- v8::Platform** platform) {
- std::unique_ptr<v8::Platform> new_platform =
- InitializeV8ForPDFiumWithStartupData(exe_path, bin_dir, natives_blob,
- snapshot_blob);
- if (!new_platform)
- return false;
- *platform = new_platform.release();
- return true;
-}
#else // V8_USE_EXTERNAL_STARTUP_DATA
std::unique_ptr<v8::Platform> InitializeV8ForPDFium(
const std::string& exe_path) {
return InitializeV8Common(exe_path);
}
-
-bool InitializeV8ForPDFium(const std::string& exe_path,
- v8::Platform** platform) {
- std::unique_ptr<v8::Platform> new_platform = InitializeV8ForPDFium(exe_path);
- if (!new_platform)
- return false;
- *platform = new_platform.release();
- return true;
-}
#endif // V8_USE_EXTERNAL_STARTUP_DATA
#endif // PDF_ENABLE_V8
diff --git a/testing/test_support.h b/testing/test_support.h
index 00d72b35d1..f26e161544 100644
--- a/testing/test_support.h
+++ b/testing/test_support.h
@@ -99,20 +99,9 @@ std::unique_ptr<v8::Platform> InitializeV8ForPDFiumWithStartupData(
const std::string& bin_dir,
v8::StartupData* natives_blob,
v8::StartupData* snapshot_blob);
-
-// TODO(thestig): Remove this in the near future once it has no callers.
-bool InitializeV8ForPDFium(const std::string& exe_path,
- const std::string& bin_dir,
- v8::StartupData* natives_blob,
- v8::StartupData* snapshot_blob,
- v8::Platform** platform);
#else // V8_USE_EXTERNAL_STARTUP_DATA
std::unique_ptr<v8::Platform> InitializeV8ForPDFium(
const std::string& exe_path);
-
-// TODO(thestig): Remove this in the near future once it has no callers.
-bool InitializeV8ForPDFium(const std::string& exe_path,
- v8::Platform** platform);
#endif // V8_USE_EXTERNAL_STARTUP_DATA
#endif // PDF_ENABLE_V8