summaryrefslogtreecommitdiff
path: root/third_party/libtiff/0007-uninitialized-value.patch
diff options
context:
space:
mode:
authordsinclair <dsinclair@chromium.org>2016-10-03 13:59:57 -0700
committerCommit bot <commit-bot@chromium.org>2016-10-03 13:59:57 -0700
commit76383db4906c9357292846ace77566b34eb47de9 (patch)
tree60b3a5fa45ffca5c8f1b0c6b834e934a88c6a82e /third_party/libtiff/0007-uninitialized-value.patch
parentabab61a1fcd776964a15c528dd2dd034fb31edf0 (diff)
downloadpdfium-76383db4906c9357292846ace77566b34eb47de9.tar.xz
Fix potentially uninitialized value.chromium/2880
Depending on what ReadOK does it's possible for |dircount16| to be used without being initialized. The read code calls back into PDFium specific code which then calls into the stream reading code. Initialize the value to be sure it is set. BUG=chromium:651632 Review-Url: https://codereview.chromium.org/2389993002
Diffstat (limited to 'third_party/libtiff/0007-uninitialized-value.patch')
-rw-r--r--third_party/libtiff/0007-uninitialized-value.patch13
1 files changed, 13 insertions, 0 deletions
diff --git a/third_party/libtiff/0007-uninitialized-value.patch b/third_party/libtiff/0007-uninitialized-value.patch
new file mode 100644
index 0000000000..f6e9806181
--- /dev/null
+++ b/third_party/libtiff/0007-uninitialized-value.patch
@@ -0,0 +1,13 @@
+diff --git a/third_party/libtiff/tif_dirread.c b/third_party/libtiff/tif_dirread.c
+index 5ef3264..bc41021 100644
+--- a/third_party/libtiff/tif_dirread.c
++++ b/third_party/libtiff/tif_dirread.c
+@@ -4443,7 +4443,7 @@ TIFFFetchDirectory(TIFF* tif, uint64 diroff, TIFFDirEntry** pdir,
+ static const char module[] = "TIFFFetchDirectory";
+
+ void* origdir;
+- uint16 dircount16;
++ uint16 dircount16 = 0;
+ uint32 dirsize;
+ TIFFDirEntry* dir;
+ uint8* ma;