diff options
| author | Nico Weber <thakis@chromium.org> | 2015-07-01 14:08:08 -0700 |
|---|---|---|
| committer | Nico Weber <thakis@chromium.org> | 2015-07-01 14:08:08 -0700 |
| commit | ae195a4242a81899708eb58e109fd0d1a9cbbeeb (patch) | |
| tree | ec71759983cc216df84a72695ea1c748516c823e /third_party | |
| parent | ac9e977a913d134c5f536eeef60a2de6941f2863 (diff) | |
| download | pdfium-ae195a4242a81899708eb58e109fd0d1a9cbbeeb.tar.xz | |
Fix some clang warnings with -Wmissing-braces in pdfium.
Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
if the first field of STRUCT is itself a struct. This can
be more simply written as:
STRUCT s = {};
which also prevents the warning from firing.
Other instances of the warning have been fixed by adding
braces where appropriate.
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1213523004.
Diffstat (limited to 'third_party')
| -rw-r--r-- | third_party/BUILD.gn | 8 | ||||
| -rw-r--r-- | third_party/third_party.gyp | 5 |
2 files changed, 13 insertions, 0 deletions
diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn index 5e7dd5f575..37e30ce06d 100644 --- a/third_party/BUILD.gn +++ b/third_party/BUILD.gn @@ -95,10 +95,18 @@ source_set("fx_agg") { } source_set("fx_lcms2") { + config("fx_lcms2_warnings") { + if (is_clang) { + # cmslut.cc is sloppy with aggregate initialization. Version 2.7 of this + # library doesn't appear to have this problem. + cflags = [ "-Wno-missing-braces" ] + } + } configs -= [ "//build/config/compiler:chromium_code" ] configs += [ "//build/config/compiler:no_chromium_code", "//third_party/pdfium:pdfium_config", + ":fx_lcms2_warnings", ] sources = [ "lcms2-2.6/include/lcms2.h", diff --git a/third_party/third_party.gyp b/third_party/third_party.gyp index 3446439aa4..79368b5a68 100644 --- a/third_party/third_party.gyp +++ b/third_party/third_party.gyp @@ -137,6 +137,11 @@ ], }], ], + 'variables': { + 'clang_warning_flags': [ + '-Wno-missing-braces', + ], + }, }, { 'target_name': 'fx_libjpeg', |