summaryrefslogtreecommitdiff
path: root/third_party
diff options
context:
space:
mode:
authorNico Weber <thakis@chromium.org>2017-03-30 17:58:40 +0000
committerChromium commit bot <commit-bot@chromium.org>2017-03-30 18:25:28 +0000
commit677329c9fa9f4f9e1a06f15e8d33d8a734cc5349 (patch)
tree76ba187aac66866219abd9918dbdd52d6fe77c88 /third_party
parent2283daac0ec65185d952c6ce23282cfc0041d6bc (diff)
downloadpdfium-677329c9fa9f4f9e1a06f15e8d33d8a734cc5349.tar.xz
Revert "Enable Wshift-negative-value in PDFium."
This reverts commit 21362ee6370e6ef0f5a8275af5afde3f127887c9. Reason for revert: Breaks win_clang. Original change's description: > Enable Wshift-negative-value in PDFium. > > BUG=chromium:507717 > > Change-Id: If0030640497ce103de7713f8497570602950a2b6 > Reviewed-on: https://pdfium-review.googlesource.com/3270 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > TBR=thestig@chromium.org,thakis@chromium.org,pdfium-reviews@googlegroups.com # Not skipping CQ checks because original CL landed > 1 day ago. BUG=chromium:507717 Change-Id: I4d482b6b7dade74373995f6d9cfdc6d1d66431a3 Reviewed-on: https://pdfium-review.googlesource.com/3410 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'third_party')
-rw-r--r--third_party/BUILD.gn10
1 files changed, 10 insertions, 0 deletions
diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn
index a24e99e7f0..33a9fa2ebe 100644
--- a/third_party/BUILD.gn
+++ b/third_party/BUILD.gn
@@ -272,11 +272,21 @@ static_library("fx_lcms2") {
}
# This is only used for standalone builds.
+config("jpeg_warnings") {
+ visibility = [ ":*" ]
+ if (is_clang) {
+ cflags = [ "-Wno-shift-negative-value" ]
+ }
+}
+
static_library("jpeg") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
"//build/config/compiler:no_chromium_code",
":pdfium_third_party_config",
+
+ # Must be after no_chromium_code for warning flags to be ordered correctly.
+ ":jpeg_warnings",
]
sources = [
"libjpeg/cderror.h",