diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-05-16 15:40:23 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-05-16 23:11:57 +0000 |
| commit | 365333552cf67b7c97c4093177e7ed7b43f540ab (patch) | |
| tree | 44dfc8a496ff586def85d34e0a07893445b79cc7 /xfa/fde/cfde_renderdevice.cpp | |
| parent | dde95d8be9bc2817e34429fc38ee6d89d6d5ab75 (diff) | |
| download | pdfium-365333552cf67b7c97c4093177e7ed7b43f540ab.tar.xz | |
CFDE_RenderDevice::m_bOwnerDevice is always false
So remove it.
But they probably wanted it to be true in one place, because
it looks like a leak. So find a better way to own the object.
Change-Id: I15937e29da5ce8b380f82cb20ee3ecc3f49b8ca3
Reviewed-on: https://pdfium-review.googlesource.com/5473
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fde/cfde_renderdevice.cpp')
| -rw-r--r-- | xfa/fde/cfde_renderdevice.cpp | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/xfa/fde/cfde_renderdevice.cpp b/xfa/fde/cfde_renderdevice.cpp index 7fb5b0352e..9236dc7800 100644 --- a/xfa/fde/cfde_renderdevice.cpp +++ b/xfa/fde/cfde_renderdevice.cpp @@ -22,9 +22,8 @@ #include "xfa/fgas/font/cfgas_fontmgr.h" #include "xfa/fgas/font/cfgas_gefont.h" -CFDE_RenderDevice::CFDE_RenderDevice(CFX_RenderDevice* pDevice, - bool bOwnerDevice) - : m_pDevice(pDevice), m_bOwnerDevice(bOwnerDevice), m_iCharCount(0) { +CFDE_RenderDevice::CFDE_RenderDevice(CFX_RenderDevice* pDevice) + : m_pDevice(pDevice), m_iCharCount(0) { ASSERT(pDevice); FX_RECT rt = m_pDevice->GetClipBox(); @@ -33,10 +32,7 @@ CFDE_RenderDevice::CFDE_RenderDevice(CFX_RenderDevice* pDevice, static_cast<float>(rt.Height())); } -CFDE_RenderDevice::~CFDE_RenderDevice() { - if (m_bOwnerDevice) - delete m_pDevice; -} +CFDE_RenderDevice::~CFDE_RenderDevice() {} int32_t CFDE_RenderDevice::GetWidth() const { return m_pDevice->GetWidth(); |