diff options
| author | Henrique Nakashima <hnakashima@chromium.org> | 2018-02-06 21:36:45 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-06 21:36:45 +0000 |
| commit | bfeab62b37a701dc82f180e49d26c602f96f96f9 (patch) | |
| tree | 114a99e1d3c0ea26f7dc15727dae0214125b4c89 /xfa/fde/cfde_texteditengine.cpp | |
| parent | f3f1869409a59adbfde4b2b546f30c81051aad14 (diff) | |
| download | pdfium-bfeab62b37a701dc82f180e49d26c602f96f96f9.tar.xz | |
Fix caret not appearing in XFA Edits.
This makes the caret appear (again?), blink, and fixes its positioning
to be a little spaced from the last character.
Known issue: when the edit is empty, the caret is not necessarily
aligned with where the text will be.
Bug: chromium:592750
Change-Id: I950b0ea236db8855c6ed50f48ec1935d97e6ccf8
Reviewed-on: https://pdfium-review.googlesource.com/25451
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'xfa/fde/cfde_texteditengine.cpp')
| -rw-r--r-- | xfa/fde/cfde_texteditengine.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/xfa/fde/cfde_texteditengine.cpp b/xfa/fde/cfde_texteditengine.cpp index d085a8d147..75fd103b3c 100644 --- a/xfa/fde/cfde_texteditengine.cpp +++ b/xfa/fde/cfde_texteditengine.cpp @@ -1071,10 +1071,8 @@ std::pair<int32_t, CFX_RectF> CFDE_TextEditEngine::GetCharacterInfo( if (it->nStart <= start_idx && start_idx < it->nStart + it->nCount) break; } - if (it == text_piece_info_.end()) { - NOTREACHED(); + if (it == text_piece_info_.end()) return {0, CFX_RectF()}; - } return {it->nBidiLevel, GetCharRects(*it)[start_idx - it->nStart]}; } |