diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-05-16 15:40:23 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-05-16 23:11:57 +0000 |
| commit | 365333552cf67b7c97c4093177e7ed7b43f540ab (patch) | |
| tree | 44dfc8a496ff586def85d34e0a07893445b79cc7 /xfa/fde/cfde_textout.h | |
| parent | dde95d8be9bc2817e34429fc38ee6d89d6d5ab75 (diff) | |
| download | pdfium-365333552cf67b7c97c4093177e7ed7b43f540ab.tar.xz | |
CFDE_RenderDevice::m_bOwnerDevice is always false
So remove it.
But they probably wanted it to be true in one place, because
it looks like a leak. So find a better way to own the object.
Change-Id: I15937e29da5ce8b380f82cb20ee3ecc3f49b8ca3
Reviewed-on: https://pdfium-review.googlesource.com/5473
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fde/cfde_textout.h')
| -rw-r--r-- | xfa/fde/cfde_textout.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/xfa/fde/cfde_textout.h b/xfa/fde/cfde_textout.h index 360c3051e9..a52814041b 100644 --- a/xfa/fde/cfde_textout.h +++ b/xfa/fde/cfde_textout.h @@ -167,6 +167,8 @@ class CFDE_TextOut { int32_t m_iCurPiece; int32_t m_iTotalLines; std::vector<FXTEXT_CHARPOS> m_CharPos; + // NOTE: m_pDefaultRenderDevice must outlive m_pRenderDevice. + std::unique_ptr<CFX_DefaultRenderDevice> m_pDefaultRenderDevice; std::unique_ptr<CFDE_RenderDevice> m_pRenderDevice; std::vector<int32_t> m_HotKeys; std::vector<CFX_RectF> m_rectArray; |