diff options
| author | tsepez <tsepez@chromium.org> | 2016-12-14 05:57:10 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-12-14 05:57:10 -0800 |
| commit | a9caab94c1f16929e5acf2676117224617d80f53 (patch) | |
| tree | d71ff9a82fae6e6080deb76375f43056127b3ee2 /xfa/fde/cfx_wordbreak.cpp | |
| parent | 992ecf7c189e5cabf43e5ad862511cf63d030966 (diff) | |
| download | pdfium-a9caab94c1f16929e5acf2676117224617d80f53.tar.xz | |
Avoid the ptr.reset(new XXX()) anti-pattern
Be suspicious of |new|. This removes some of the
easy cases.
Review-Url: https://codereview.chromium.org/2571913002
Diffstat (limited to 'xfa/fde/cfx_wordbreak.cpp')
| -rw-r--r-- | xfa/fde/cfx_wordbreak.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xfa/fde/cfx_wordbreak.cpp b/xfa/fde/cfx_wordbreak.cpp index 48b45a4e82..2d37ba1707 100644 --- a/xfa/fde/cfx_wordbreak.cpp +++ b/xfa/fde/cfx_wordbreak.cpp @@ -8,6 +8,7 @@ #include <utility> +#include "third_party/base/ptr_util.h" #include "xfa/fde/cfx_chariter.h" namespace { @@ -2788,7 +2789,7 @@ void CFX_WordBreak::Attach(IFX_CharIter* pIter) { } void CFX_WordBreak::Attach(const CFX_WideString& wsText) { - m_pCurIter.reset(new CFX_CharIter(wsText)); + m_pCurIter = pdfium::MakeUnique<CFX_CharIter>(wsText); } bool CFX_WordBreak::Next(bool bPrev) { |