diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-02-08 10:05:05 -0500 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-02-09 15:55:20 +0000 |
| commit | 21e954b59fcef1b84fdcdb9ae337e2d4c060b19e (patch) | |
| tree | 2053cd0a8b0d4c1bb6903db3aa6f753a23afedcf /xfa/fde/css/cfde_csscustomproperty.h | |
| parent | 1b08df18300bbc67dabd12fb35ab6ce1732a1024 (diff) | |
| download | pdfium-21e954b59fcef1b84fdcdb9ae337e2d4c060b19e.tar.xz | |
Remove CopyToLocal from CFDE_CSSDeclaration
This CL removes the CopyToLocal method and creates CFX_WideString's directly.
This fixes several memory leaks as the CopyToLocal strings were not cleaned
up correctly.
Change-Id: Ie5ba4cdc4d713cd0b8e3fb85e02f27dc09f38af1
Reviewed-on: https://pdfium-review.googlesource.com/2553
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fde/css/cfde_csscustomproperty.h')
| -rw-r--r-- | xfa/fde/css/cfde_csscustomproperty.h | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/xfa/fde/css/cfde_csscustomproperty.h b/xfa/fde/css/cfde_csscustomproperty.h index 6e99630e1c..6970d49cbb 100644 --- a/xfa/fde/css/cfde_csscustomproperty.h +++ b/xfa/fde/css/cfde_csscustomproperty.h @@ -11,8 +11,17 @@ class CFDE_CSSCustomProperty { public: - const FX_WCHAR* pwsName; - const FX_WCHAR* pwsValue; + CFDE_CSSCustomProperty(const CFX_WideString& name, + const CFX_WideString& value); + CFDE_CSSCustomProperty(const CFDE_CSSCustomProperty& prop); + ~CFDE_CSSCustomProperty(); + + CFX_WideString name() const { return name_; } + CFX_WideString value() const { return value_; } + + private: + CFX_WideString name_; + CFX_WideString value_; }; #endif // XFA_FDE_CSS_CFDE_CSSCUSTOMPROPERTY_H_ |