diff options
| author | tsepez <tsepez@chromium.org> | 2016-05-11 10:26:05 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-05-11 10:26:05 -0700 |
| commit | f74ad998d2e8d2636fb25e94823946a3b151e34e (patch) | |
| tree | 0b18e0a29fdc4bf1cce66ea437d8a4841b3daf4a /xfa/fde/fde_iterator.h | |
| parent | 2c3a16a7698ba15476173e849f82c97ea3da9939 (diff) | |
| download | pdfium-f74ad998d2e8d2636fb25e94823946a3b151e34e.tar.xz | |
Replace some calls to Release() with direct delete, part 1.
Searching for the anti-pattern:
void Release() { delete this; }
We must be explicit on the ownership model.
Add unique_ptrs as a result.
Review-Url: https://codereview.chromium.org/1960673003
Diffstat (limited to 'xfa/fde/fde_iterator.h')
| -rw-r--r-- | xfa/fde/fde_iterator.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/xfa/fde/fde_iterator.h b/xfa/fde/fde_iterator.h index 4d089254ea..4f3fdf3f29 100644 --- a/xfa/fde/fde_iterator.h +++ b/xfa/fde/fde_iterator.h @@ -20,9 +20,7 @@ struct FDE_CANVASITEM { class CFDE_VisualSetIterator : public CFX_Target { public: CFDE_VisualSetIterator(); - ~CFDE_VisualSetIterator(); - - void Release() { delete this; } + ~CFDE_VisualSetIterator() override; FX_BOOL AttachCanvas(IFDE_CanvasSet* pCanvas); FX_BOOL FilterObjects(uint32_t dwObjects = 0xFFFFFFFF); |