diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-04-04 15:10:00 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-04 19:54:55 +0000 |
| commit | 93bfc262074abf003ba4ab0ff1d9767d8dfa9a3d (patch) | |
| tree | fd2c2c9d0a99923d397501f85e780498928a7e35 /xfa/fde/xml/cfde_xmlinstruction.cpp | |
| parent | b2fb20e0f8e7ea368c541d35ccb61506041f7ddd (diff) | |
| download | pdfium-93bfc262074abf003ba4ab0ff1d9767d8dfa9a3d.tar.xz | |
Cleanup CFDE_XMLCharData and CFDE_XMLText
This Cl switchs CFDE_XMLCharData to subclass CFDE_XMLText and cleans up
the code which was the same except for the accessor names.
Change-Id: I85ebf4f3f19f0d15be4dd77a71b89ca8083f4b1e
Reviewed-on: https://pdfium-review.googlesource.com/3672
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Diffstat (limited to 'xfa/fde/xml/cfde_xmlinstruction.cpp')
| -rw-r--r-- | xfa/fde/xml/cfde_xmlinstruction.cpp | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/xfa/fde/xml/cfde_xmlinstruction.cpp b/xfa/fde/xml/cfde_xmlinstruction.cpp index 64c980b439..2229b4768a 100644 --- a/xfa/fde/xml/cfde_xmlinstruction.cpp +++ b/xfa/fde/xml/cfde_xmlinstruction.cpp @@ -7,6 +7,7 @@ #include "xfa/fde/xml/cfde_xmlinstruction.h" #include "core/fxcrt/fx_ext.h" +#include "third_party/base/ptr_util.h" #include "third_party/base/stl_util.h" CFDE_XMLInstruction::CFDE_XMLInstruction(const CFX_WideString& wsTarget) @@ -20,16 +21,10 @@ FDE_XMLNODETYPE CFDE_XMLInstruction::GetType() const { return FDE_XMLNODE_Instruction; } -CFDE_XMLNode* CFDE_XMLInstruction::Clone(bool bRecursive) { - CFDE_XMLInstruction* pClone = new CFDE_XMLInstruction(m_wsTarget); - if (!pClone) - return nullptr; - +std::unique_ptr<CFDE_XMLNode> CFDE_XMLInstruction::Clone() { + auto pClone = pdfium::MakeUnique<CFDE_XMLInstruction>(m_wsTarget); pClone->m_Attributes = m_Attributes; pClone->m_TargetData = m_TargetData; - if (bRecursive) - CloneChildren(pClone); - return pClone; } |