summaryrefslogtreecommitdiff
path: root/xfa/fde
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2017-03-10 14:37:14 -0800
committerChromium commit bot <commit-bot@chromium.org>2017-03-13 19:28:30 +0000
commit375c2764b56b38cc9326a8f8ef668fbf78234e9a (patch)
treeee1056ac37b855135c8c5a544d4716c3d1a9c7b1 /xfa/fde
parent723987910fb195e454aab28e1088df4f9ccf0d6e (diff)
downloadpdfium-375c2764b56b38cc9326a8f8ef668fbf78234e9a.tar.xz
Make most PDFium code pass Clang plugin's auto raw check.
Change-Id: I9dc32342e24361389841ecba83081a97fc043377 Reviewed-on: https://pdfium-review.googlesource.com/2959 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'xfa/fde')
-rw-r--r--xfa/fde/cfde_txtedttextset.cpp2
-rw-r--r--xfa/fde/css/cfde_cssstyleselector.cpp10
-rw-r--r--xfa/fde/css/cfde_cssstylesheet.cpp2
-rw-r--r--xfa/fde/css/cfde_cssstylesheet_unittest.cpp2
4 files changed, 8 insertions, 8 deletions
diff --git a/xfa/fde/cfde_txtedttextset.cpp b/xfa/fde/cfde_txtedttextset.cpp
index 1f86dabcdd..a6503f4022 100644
--- a/xfa/fde/cfde_txtedttextset.cpp
+++ b/xfa/fde/cfde_txtedttextset.cpp
@@ -78,7 +78,7 @@ std::vector<CFX_RectF> CFDE_TxtEdtTextSet::GetCharRects(
if (!pPiece || pPiece->nCount < 1)
return std::vector<CFX_RectF>();
- auto pEngine = static_cast<CFDE_TxtEdtEngine*>(m_pPage->GetEngine());
+ auto* pEngine = static_cast<CFDE_TxtEdtEngine*>(m_pPage->GetEngine());
const FDE_TXTEDTPARAMS* pTextParams = pEngine->GetEditParams();
uint32_t dwLayoutStyle = pEngine->GetTextBreak()->GetLayoutStyles();
FX_TXTRUN tr;
diff --git a/xfa/fde/css/cfde_cssstyleselector.cpp b/xfa/fde/css/cfde_cssstyleselector.cpp
index 5a7aa1b7ff..08cd0e9251 100644
--- a/xfa/fde/css/cfde_cssstyleselector.cpp
+++ b/xfa/fde/css/cfde_cssstyleselector.cpp
@@ -56,7 +56,7 @@ CFDE_CSSStyleSelector::MatchDeclarations(const CFX_WideString& tagname) {
if (m_UARules.CountSelectors() == 0 || tagname.IsEmpty())
return matchedDecls;
- auto rules = m_UARules.GetTagRuleData(tagname);
+ auto* rules = m_UARules.GetTagRuleData(tagname);
if (!rules)
return matchedDecls;
@@ -106,19 +106,19 @@ void CFDE_CSSStyleSelector::ApplyDeclarations(
std::vector<const CFDE_CSSPropertyHolder*> normals;
std::vector<const CFDE_CSSCustomProperty*> customs;
- for (auto& decl : declArray)
+ for (auto* decl : declArray)
ExtractValues(decl, &importants, &normals, &customs);
if (extraDecl)
ExtractValues(extraDecl, &importants, &normals, &customs);
- for (auto& prop : normals)
+ for (auto* prop : normals)
ApplyProperty(prop->eProperty, prop->pValue, pComputedStyle);
- for (auto& prop : customs)
+ for (auto* prop : customs)
pComputedStyle->AddCustomStyle(*prop);
- for (auto& prop : importants)
+ for (auto* prop : importants)
ApplyProperty(prop->eProperty, prop->pValue, pComputedStyle);
}
diff --git a/xfa/fde/css/cfde_cssstylesheet.cpp b/xfa/fde/css/cfde_cssstylesheet.cpp
index c8bf70ec23..e259e2f332 100644
--- a/xfa/fde/css/cfde_cssstylesheet.cpp
+++ b/xfa/fde/css/cfde_cssstylesheet.cpp
@@ -85,7 +85,7 @@ FDE_CSSSyntaxStatus CFDE_CSSStyleSheet::LoadStyleRule(
case FDE_CSSSyntaxStatus::PropertyValue: {
if (propertyTable || iValueLen > 0) {
CFX_WideStringC strValue = pSyntax->GetCurrentString();
- auto decl = pStyleRule->GetDeclaration();
+ auto* decl = pStyleRule->GetDeclaration();
if (!strValue.IsEmpty()) {
if (propertyTable) {
decl->AddProperty(propertyTable, strValue);
diff --git a/xfa/fde/css/cfde_cssstylesheet_unittest.cpp b/xfa/fde/css/cfde_cssstylesheet_unittest.cpp
index fa73a7a9ba..9d8ecb9347 100644
--- a/xfa/fde/css/cfde_cssstylesheet_unittest.cpp
+++ b/xfa/fde/css/cfde_cssstylesheet_unittest.cpp
@@ -143,7 +143,7 @@ TEST_F(CFDE_CSSStyleSheetTest, ParseChildSelectors) {
CFDE_CSSStyleRule* style = sheet_->GetRule(0);
EXPECT_EQ(1UL, style->CountSelectorLists());
- auto sel = style->GetSelectorList(0);
+ auto* sel = style->GetSelectorList(0);
EXPECT_TRUE(sel != nullptr);
EXPECT_EQ(FX_HashCode_GetW(L"c", true), sel->GetNameHash());