diff options
| author | Lei Zhang <thestig@chromium.org> | 2017-05-22 17:05:40 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-05-23 00:18:13 +0000 |
| commit | b45324bfb414acc595e478dc7dc63ac43c792580 (patch) | |
| tree | 90af2bb4c6386b2b2825c80d7405dace0416c69b /xfa/fde | |
| parent | 4cb82ee95256f110489f2b503e70729c44419e74 (diff) | |
| download | pdfium-b45324bfb414acc595e478dc7dc63ac43c792580.tar.xz | |
Use NOTREACHED() in more places.
Change-Id: I88466943171f19259f84add69679741d44c8e123
Reviewed-on: https://pdfium-review.googlesource.com/5551
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fde')
| -rw-r--r-- | xfa/fde/cfde_rendercontext.cpp | 3 | ||||
| -rw-r--r-- | xfa/fde/css/cfde_cssdeclaration.cpp | 3 | ||||
| -rw-r--r-- | xfa/fde/css/cfde_cssstyleselector.cpp | 3 | ||||
| -rw-r--r-- | xfa/fde/css/cfde_csssyntaxparser.cpp | 3 |
4 files changed, 8 insertions, 4 deletions
diff --git a/xfa/fde/cfde_rendercontext.cpp b/xfa/fde/cfde_rendercontext.cpp index af90ff7f13..702f7ce295 100644 --- a/xfa/fde/cfde_rendercontext.cpp +++ b/xfa/fde/cfde_rendercontext.cpp @@ -6,6 +6,7 @@ #include "xfa/fde/cfde_rendercontext.h" +#include "third_party/base/logging.h" #include "third_party/base/ptr_util.h" #include "xfa/fde/cfde_brush.h" #include "xfa/fde/cfde_renderdevice.h" @@ -64,7 +65,7 @@ void CFDE_RenderContext::DoRender() { iCount += 5; break; case FDE_VISUALOBJ_Canvas: - ASSERT(false); + NOTREACHED(); break; default: break; diff --git a/xfa/fde/css/cfde_cssdeclaration.cpp b/xfa/fde/css/cfde_cssdeclaration.cpp index 4179e61f5d..00a2c9e33c 100644 --- a/xfa/fde/css/cfde_cssdeclaration.cpp +++ b/xfa/fde/css/cfde_cssdeclaration.cpp @@ -7,6 +7,7 @@ #include "xfa/fde/css/cfde_cssdeclaration.h" #include "core/fxcrt/fx_extension.h" +#include "third_party/base/logging.h" #include "third_party/base/ptr_util.h" #include "xfa/fde/css/cfde_csscolorvalue.h" #include "xfa/fde/css/cfde_csscustomproperty.h" @@ -265,7 +266,7 @@ void CFDE_CSSDeclaration::AddProperty(const FDE_CSSPropertyTable* pTable, ParseValueListProperty(pTable, pszValue, iValueLen, bImportant); return; default: - ASSERT(false); + NOTREACHED(); break; } } diff --git a/xfa/fde/css/cfde_cssstyleselector.cpp b/xfa/fde/css/cfde_cssstyleselector.cpp index 42cc7afc23..024c8a86e2 100644 --- a/xfa/fde/css/cfde_cssstyleselector.cpp +++ b/xfa/fde/css/cfde_cssstyleselector.cpp @@ -9,6 +9,7 @@ #include <algorithm> #include <utility> +#include "third_party/base/logging.h" #include "third_party/base/ptr_util.h" #include "xfa/fde/css/cfde_csscolorvalue.h" #include "xfa/fde/css/cfde_csscomputedstyle.h" @@ -412,7 +413,7 @@ void CFDE_CSSStyleSelector::ApplyProperty( } } } else { - ASSERT(false); + NOTREACHED(); } } diff --git a/xfa/fde/css/cfde_csssyntaxparser.cpp b/xfa/fde/css/cfde_csssyntaxparser.cpp index bc861bdd6e..e943f29f4d 100644 --- a/xfa/fde/css/cfde_csssyntaxparser.cpp +++ b/xfa/fde/css/cfde_csssyntaxparser.cpp @@ -10,6 +10,7 @@ #include "core/fxcrt/fx_codepage.h" #include "core/fxcrt/fx_extension.h" +#include "third_party/base/logging.h" #include "xfa/fde/css/cfde_cssdeclaration.h" #include "xfa/fde/css/fde_cssdatatable.h" @@ -182,7 +183,7 @@ FDE_CSSSyntaxStatus CFDE_CSSSyntaxParser::DoSyntaxParse() { m_TextPlane.MoveNext(); break; default: - ASSERT(false); + NOTREACHED(); break; } } |