diff options
author | Dan Sinclair <dsinclair@chromium.org> | 2016-11-21 13:50:32 -0500 |
---|---|---|
committer | dan sinclair <dsinclair@chromium.org> | 2016-11-21 18:51:10 +0000 |
commit | 85c8e7f788512ce5b5b43cd816e8091b57c3d5e7 (patch) | |
tree | e727d747684b9db2632ef250b55046cfce2b55a3 /xfa/fde | |
parent | 7daa6fb286d1b5d65f99521f3314083e86d93e3f (diff) | |
download | pdfium-85c8e7f788512ce5b5b43cd816e8091b57c3d5e7.tar.xz |
Fixup lint flags.
The -build/include setting was masking out build/include_what_you_use. This CL
restores them, fixes any build errors, and adds NOLINT as needed. As well,
the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd.
lint cleanups
Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f
Reviewed-on: https://pdfium-review.googlesource.com/2030
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fde')
-rw-r--r-- | xfa/fde/cfde_txtedtbuf.cpp | 2 | ||||
-rw-r--r-- | xfa/fde/cfde_txtedtbufiter.h | 2 | ||||
-rw-r--r-- | xfa/fde/cfde_txtedtengine.cpp | 2 | ||||
-rw-r--r-- | xfa/fde/cfde_txtedtparag.cpp | 2 | ||||
-rw-r--r-- | xfa/fde/cfx_wordbreak.cpp | 2 | ||||
-rw-r--r-- | xfa/fde/css/cfde_cssrulecollection.cpp | 1 | ||||
-rw-r--r-- | xfa/fde/css/fde_cssstyleselector.h | 2 | ||||
-rw-r--r-- | xfa/fde/css/fde_cssstylesheet.h | 2 | ||||
-rw-r--r-- | xfa/fde/fde_gedevice.cpp | 1 | ||||
-rw-r--r-- | xfa/fde/xml/fde_xml_imp_unittest.cpp | 2 |
10 files changed, 14 insertions, 4 deletions
diff --git a/xfa/fde/cfde_txtedtbuf.cpp b/xfa/fde/cfde_txtedtbuf.cpp index 6d36eb3da2..b01081e3c9 100644 --- a/xfa/fde/cfde_txtedtbuf.cpp +++ b/xfa/fde/cfde_txtedtbuf.cpp @@ -6,6 +6,8 @@ #include "xfa/fde/cfde_txtedtbuf.h" +#include <algorithm> + #include "xfa/fgas/crt/fgas_memory.h" namespace { diff --git a/xfa/fde/cfde_txtedtbufiter.h b/xfa/fde/cfde_txtedtbufiter.h index 4322708a2a..c536aafc82 100644 --- a/xfa/fde/cfde_txtedtbufiter.h +++ b/xfa/fde/cfde_txtedtbufiter.h @@ -14,7 +14,7 @@ class CFDE_TxtEdtBuf; class CFDE_TxtEdtBufIter : public IFX_CharIter { public: - CFDE_TxtEdtBufIter(CFDE_TxtEdtBuf* pBuf, FX_WCHAR wcAlias = 0); + explicit CFDE_TxtEdtBufIter(CFDE_TxtEdtBuf* pBuf, FX_WCHAR wcAlias = 0); ~CFDE_TxtEdtBufIter() override; bool Next(bool bPrev = false) override; diff --git a/xfa/fde/cfde_txtedtengine.cpp b/xfa/fde/cfde_txtedtengine.cpp index e0e788144a..ad20b04feb 100644 --- a/xfa/fde/cfde_txtedtengine.cpp +++ b/xfa/fde/cfde_txtedtengine.cpp @@ -6,6 +6,8 @@ #include "xfa/fde/cfde_txtedtengine.h" +#include <algorithm> + #include "xfa/fde/cfde_txtedtbuf.h" #include "xfa/fde/cfde_txtedtbufiter.h" #include "xfa/fde/cfde_txtedtdorecord_deleterange.h" diff --git a/xfa/fde/cfde_txtedtparag.cpp b/xfa/fde/cfde_txtedtparag.cpp index 6e6a664ff2..244add4e0a 100644 --- a/xfa/fde/cfde_txtedtparag.cpp +++ b/xfa/fde/cfde_txtedtparag.cpp @@ -6,6 +6,8 @@ #include "xfa/fde/cfde_txtedtparag.h" +#include <memory> + #include "xfa/fde/cfde_txtedtbuf.h" #include "xfa/fde/cfde_txtedtbufiter.h" #include "xfa/fde/cfde_txtedtengine.h" diff --git a/xfa/fde/cfx_wordbreak.cpp b/xfa/fde/cfx_wordbreak.cpp index 04fc32f550..48b45a4e82 100644 --- a/xfa/fde/cfx_wordbreak.cpp +++ b/xfa/fde/cfx_wordbreak.cpp @@ -6,6 +6,8 @@ #include "xfa/fde/cfx_wordbreak.h" +#include <utility> + #include "xfa/fde/cfx_chariter.h" namespace { diff --git a/xfa/fde/css/cfde_cssrulecollection.cpp b/xfa/fde/css/cfde_cssrulecollection.cpp index 28a482b834..2f91c13628 100644 --- a/xfa/fde/css/cfde_cssrulecollection.cpp +++ b/xfa/fde/css/cfde_cssrulecollection.cpp @@ -11,7 +11,6 @@ #include "xfa/fde/css/fde_csscache.h" #include "xfa/fde/css/fde_cssdeclaration.h" -#include "xfa/fde/css/fde_cssstyleselector.h" #include "xfa/fde/css/fde_cssstylesheet.h" #include "xfa/fde/css/fde_csssyntax.h" #include "xfa/fxfa/app/xfa_textlayout.h" diff --git a/xfa/fde/css/fde_cssstyleselector.h b/xfa/fde/css/fde_cssstyleselector.h index 8ef3885823..0096b7a34a 100644 --- a/xfa/fde/css/fde_cssstyleselector.h +++ b/xfa/fde/css/fde_cssstyleselector.h @@ -353,7 +353,7 @@ class CFDE_CSSComputedStyle : public IFDE_CSSComputedStyle, public IFDE_CSSParagraphStyle, public CFX_Target { public: - CFDE_CSSComputedStyle(IFX_MemoryAllocator* pAlloc); + explicit CFDE_CSSComputedStyle(IFX_MemoryAllocator* pAlloc); ~CFDE_CSSComputedStyle() override; // IFX_Retainable diff --git a/xfa/fde/css/fde_cssstylesheet.h b/xfa/fde/css/fde_cssstylesheet.h index 0fe63477d3..7d3ec98844 100644 --- a/xfa/fde/css/fde_cssstylesheet.h +++ b/xfa/fde/css/fde_cssstylesheet.h @@ -96,7 +96,7 @@ class CFDE_CSSFontFaceRule : public IFDE_CSSFontFaceRule, public CFX_Target { class CFDE_CSSStyleSheet : public IFDE_CSSStyleSheet, public CFX_Target { public: - CFDE_CSSStyleSheet(uint32_t dwMediaList); + explicit CFDE_CSSStyleSheet(uint32_t dwMediaList); ~CFDE_CSSStyleSheet() override; // IFX_Retainable: diff --git a/xfa/fde/fde_gedevice.cpp b/xfa/fde/fde_gedevice.cpp index 4adfd54af4..254193659d 100644 --- a/xfa/fde/fde_gedevice.cpp +++ b/xfa/fde/fde_gedevice.cpp @@ -7,6 +7,7 @@ #include "xfa/fde/fde_gedevice.h" #include <algorithm> +#include <memory> #include "core/fxge/cfx_gemodule.h" #include "core/fxge/cfx_graphstatedata.h" diff --git a/xfa/fde/xml/fde_xml_imp_unittest.cpp b/xfa/fde/xml/fde_xml_imp_unittest.cpp index f0d0bca2ca..e5bcb0acb2 100644 --- a/xfa/fde/xml/fde_xml_imp_unittest.cpp +++ b/xfa/fde/xml/fde_xml_imp_unittest.cpp @@ -4,6 +4,8 @@ #include "xfa/fde/xml/fde_xml_imp.h" +#include <memory> + #include "testing/gtest/include/gtest/gtest.h" #include "xfa/fgas/crt/fgas_stream.h" |