diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-04-11 09:03:14 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-11 14:24:24 +0000 |
| commit | d7120eead6f6e0b05c1197e55e899081deae1289 (patch) | |
| tree | 824819037adf17bc2b291f5f0dbc922510a8ffe2 /xfa/fgas/crt/ifgas_stream.h | |
| parent | 96e65ae3a3a328022f025805e9db02cbed1b5607 (diff) | |
| download | pdfium-d7120eead6f6e0b05c1197e55e899081deae1289.tar.xz | |
Disabiguate CreateStream calls
This CL creates a CreateReadStream and CreateWriteStream method instead
of having a single overloaded method. This removes the need for the cast
at the call sites. The access parameter has been rolled into the method
as it was always passed the same way to each Create*Stream method.
Change-Id: I845951c3fe386b8051daf4f6b2ee5ba29b5c7d54
Reviewed-on: https://pdfium-review.googlesource.com/4032
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fgas/crt/ifgas_stream.h')
| -rw-r--r-- | xfa/fgas/crt/ifgas_stream.h | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/xfa/fgas/crt/ifgas_stream.h b/xfa/fgas/crt/ifgas_stream.h index 01a148019f..31d1e67589 100644 --- a/xfa/fgas/crt/ifgas_stream.h +++ b/xfa/fgas/crt/ifgas_stream.h @@ -13,7 +13,6 @@ enum FX_STREAMACCESS { FX_STREAMACCESS_Binary = 0x00, - FX_STREAMACCESS_Text = 0x01, FX_STREAMACCESS_Read = 0x02, FX_STREAMACCESS_Write = 0x04, FX_STREAMACCESS_Truncate = 0x10, @@ -29,15 +28,12 @@ enum FX_STREAMSEEK { class IFGAS_Stream : public CFX_Retainable { public: - static CFX_RetainPtr<IFGAS_Stream> CreateStream( - const CFX_RetainPtr<IFX_SeekableReadStream>& pFileRead, - uint32_t dwAccess); - static CFX_RetainPtr<IFGAS_Stream> CreateStream( - const CFX_RetainPtr<IFX_SeekableWriteStream>& pFileWrite, - uint32_t dwAccess); + static CFX_RetainPtr<IFGAS_Stream> CreateReadStream( + const CFX_RetainPtr<IFX_SeekableReadStream>& pFileRead); + static CFX_RetainPtr<IFGAS_Stream> CreateWriteStream( + const CFX_RetainPtr<IFX_SeekableWriteStream>& pFileWrite); static CFX_RetainPtr<IFGAS_Stream> CreateStream(uint8_t* pData, - int32_t length, - uint32_t dwAccess); + int32_t length); virtual uint32_t GetAccessModes() const = 0; virtual int32_t GetLength() const = 0; |