diff options
| author | tsepez <tsepez@chromium.org> | 2016-11-30 15:10:55 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-11-30 15:10:55 -0800 |
| commit | 345d489b70a8e057587512524e69bd5692e2e14b (patch) | |
| tree | 01a34c53a991ef069b503bed1b8d1845510cfe04 /xfa/fgas/crt | |
| parent | 47718fbaf24000877aff58d9512b9b1dea0af818 (diff) | |
| download | pdfium-345d489b70a8e057587512524e69bd5692e2e14b.tar.xz | |
Convert loose FX_Create* functions into static methods
Also remove a bool that is always false.
Review-Url: https://codereview.chromium.org/2539203002
Diffstat (limited to 'xfa/fgas/crt')
| -rw-r--r-- | xfa/fgas/crt/fgas_stream.cpp | 6 | ||||
| -rw-r--r-- | xfa/fgas/crt/fgas_stream.h | 5 |
2 files changed, 5 insertions, 6 deletions
diff --git a/xfa/fgas/crt/fgas_stream.cpp b/xfa/fgas/crt/fgas_stream.cpp index c3850c00bb..73d3d0b661 100644 --- a/xfa/fgas/crt/fgas_stream.cpp +++ b/xfa/fgas/crt/fgas_stream.cpp @@ -1452,10 +1452,8 @@ IFX_Stream* CFX_Stream::CreateSharedStream(uint32_t dwAccess, return pShared; } -IFX_SeekableReadStream* FX_CreateFileRead(IFX_Stream* pBaseStream, - bool bReleaseStream) { - ASSERT(pBaseStream); - return new CFGAS_FileRead(pBaseStream, bReleaseStream); +IFX_SeekableReadStream* IFX_Stream::MakeSeekableReadStream() { + return new CFGAS_FileRead(this, false); } CFGAS_FileRead::CFGAS_FileRead(IFX_Stream* pStream, bool bReleaseStream) diff --git a/xfa/fgas/crt/fgas_stream.h b/xfa/fgas/crt/fgas_stream.h index 674007e935..413927d22f 100644 --- a/xfa/fgas/crt/fgas_stream.h +++ b/xfa/fgas/crt/fgas_stream.h @@ -37,6 +37,7 @@ class IFX_Stream { uint32_t dwAccess); static IFX_Stream* CreateTextStream(IFX_Stream* pBaseStream, bool bDeleteOnRelease); + virtual ~IFX_Stream() {} virtual void Release() = 0; virtual IFX_Stream* Retain() = 0; @@ -61,9 +62,9 @@ class IFX_Stream { virtual int32_t GetBOM(uint8_t bom[4]) const = 0; virtual uint16_t GetCodePage() const = 0; virtual uint16_t SetCodePage(uint16_t wCodePage) = 0; + + IFX_SeekableReadStream* MakeSeekableReadStream(); }; -IFX_SeekableReadStream* FX_CreateFileRead(IFX_Stream* pBaseStream, - bool bReleaseStream); #endif // XFA_FGAS_CRT_FGAS_STREAM_H_ |