diff options
| author | Henrique Nakashima <hnakashima@chromium.org> | 2018-05-22 13:45:08 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-05-22 13:45:08 +0000 |
| commit | a3ee6a0081ab16a2034b36d1d0f9b6907aec67d2 (patch) | |
| tree | addf5f561a0c94a3f250833bb075bf10e2998d64 /xfa/fgas/font/cfgas_gefont.h | |
| parent | b9d556e4282329c7bf6a0710ce6d742467e44e84 (diff) | |
| download | pdfium-a3ee6a0081ab16a2034b36d1d0f9b6907aec67d2.tar.xz | |
Fix spaces too wide in XFA Dropdown.
CFGAS_PDFFontMgr::GetCharWidth() is only used for spaces, for no
good reason I could find. It's broken in this case too, returning
a default value of 600 for any character.
This CL removes this method and its only usage that led to finding
this issue.
Bug: pdfium:1083
Change-Id: I954de45101715b5af05169612fb5eca1b1a170b4
Reviewed-on: https://pdfium-review.googlesource.com/32740
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fgas/font/cfgas_gefont.h')
| -rw-r--r-- | xfa/fgas/font/cfgas_gefont.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/xfa/fgas/font/cfgas_gefont.h b/xfa/fgas/font/cfgas_gefont.h index ab72f1356f..f4d729d3a5 100644 --- a/xfa/fgas/font/cfgas_gefont.h +++ b/xfa/fgas/font/cfgas_gefont.h @@ -49,10 +49,6 @@ class CFGAS_GEFont : public Retainable { RetainPtr<CFGAS_GEFont> GetSubstFont(int32_t iGlyphIndex); CFX_Font* GetDevFont() const { return m_pFont; } - void SetFontProvider(CFGAS_PDFFontMgr* pProvider) { - m_pProvider.Reset(pProvider); - } - void SetLogicalFontStyle(uint32_t dwLogFontStyle) { m_bUseLogFontStyle = true; m_dwLogFontStyle = dwLogFontStyle; @@ -82,7 +78,6 @@ class CFGAS_GEFont : public Retainable { bool m_bExternalFont; RetainPtr<CFGAS_GEFont> m_pSrcFont; // Only set by ctor, so no cycles. CFGAS_FontMgr::ObservedPtr m_pFontMgr; - CFGAS_PDFFontMgr::ObservedPtr m_pProvider; RetainPtr<IFX_SeekableReadStream> m_pFileRead; std::unique_ptr<CFX_UnicodeEncoding> m_pFontEncoding; std::map<wchar_t, int32_t> m_CharWidthMap; |