summaryrefslogtreecommitdiff
path: root/xfa/fgas/font/fgas_gefont.cpp
diff options
context:
space:
mode:
authorweili <weili@chromium.org>2016-09-01 17:10:12 -0700
committerCommit bot <commit-bot@chromium.org>2016-09-01 17:10:12 -0700
commit6708106e6a3d54f3370c871ebf6643d1ecf58999 (patch)
tree97928e4492dd25692a7677b0e35339f8ee1614cf /xfa/fgas/font/fgas_gefont.cpp
parent7c5d090719a25f0c1b81fb6b46544b9394a7fdd2 (diff)
downloadpdfium-6708106e6a3d54f3370c871ebf6643d1ecf58999.tar.xz
Fix leaked internal font
In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which is never released. It needs to be correctly marked as internal font to be released. Fix this by adding a boolean parameter and pass it along during the creation of the font. BUG=pdfium:242 Review-Url: https://codereview.chromium.org/2297303004
Diffstat (limited to 'xfa/fgas/font/fgas_gefont.cpp')
-rw-r--r--xfa/fgas/font/fgas_gefont.cpp41
1 files changed, 31 insertions, 10 deletions
diff --git a/xfa/fgas/font/fgas_gefont.cpp b/xfa/fgas/font/fgas_gefont.cpp
index 1507fa4840..33d17489fa 100644
--- a/xfa/fgas/font/fgas_gefont.cpp
+++ b/xfa/fgas/font/fgas_gefont.cpp
@@ -34,10 +34,21 @@ CFGAS_GEFont* CFGAS_GEFont::LoadFont(const FX_WCHAR* pszFontFamily,
}
// static
-CFGAS_GEFont* CFGAS_GEFont::LoadFont(CFX_Font* pExtFont,
+CFGAS_GEFont* CFGAS_GEFont::LoadFont(CFX_Font* pExternalFont,
IFGAS_FontMgr* pFontMgr) {
CFGAS_GEFont* pFont = new CFGAS_GEFont(pFontMgr);
- if (!pFont->LoadFontInternal(pExtFont)) {
+ if (!pFont->LoadFontInternal(pExternalFont)) {
+ pFont->Release();
+ return nullptr;
+ }
+ return pFont;
+}
+
+// static
+CFGAS_GEFont* CFGAS_GEFont::LoadFont(std::unique_ptr<CFX_Font> pInternalFont,
+ IFGAS_FontMgr* pFontMgr) {
+ CFGAS_GEFont* pFont = new CFGAS_GEFont(pFontMgr);
+ if (!pFont->LoadFontInternal(std::move(pInternalFont))) {
pFont->Release();
return nullptr;
}
@@ -79,7 +90,7 @@ CFGAS_GEFont::CFGAS_GEFont(IFGAS_FontMgr* pFontMgr)
m_pFont(nullptr),
m_pFontMgr(pFontMgr),
m_iRefCount(1),
- m_bExtFont(FALSE),
+ m_bExternalFont(false),
m_pProvider(nullptr) {
}
@@ -92,7 +103,7 @@ CFGAS_GEFont::CFGAS_GEFont(const CFGAS_GEFont& src, uint32_t dwFontStyles)
m_pFont(nullptr),
m_pFontMgr(src.m_pFontMgr),
m_iRefCount(1),
- m_bExtFont(FALSE),
+ m_bExternalFont(false),
m_pProvider(nullptr) {
ASSERT(src.m_pFont);
m_pFont = new CFX_Font;
@@ -117,7 +128,7 @@ CFGAS_GEFont::~CFGAS_GEFont() {
m_SubstFonts.RemoveAll();
m_FontMapper.clear();
- if (!m_bExtFont)
+ if (!m_bExternalFont)
delete m_pFont;
}
@@ -209,12 +220,22 @@ FX_BOOL CFGAS_GEFont::LoadFontInternal(IFX_Stream* pFontStream,
}
#endif // _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
-FX_BOOL CFGAS_GEFont::LoadFontInternal(CFX_Font* pExtFont) {
- if (m_pFont || !pExtFont) {
+FX_BOOL CFGAS_GEFont::LoadFontInternal(CFX_Font* pExternalFont) {
+ if (m_pFont || !pExternalFont)
return FALSE;
- }
- m_pFont = pExtFont;
- m_bExtFont = TRUE;
+
+ m_pFont = pExternalFont;
+ m_bExternalFont = true;
+ return InitFont();
+}
+
+FX_BOOL CFGAS_GEFont::LoadFontInternal(
+ std::unique_ptr<CFX_Font> pInternalFont) {
+ if (m_pFont || !pInternalFont)
+ return FALSE;
+
+ m_pFont = pInternalFont.release();
+ m_bExternalFont = false;
return InitFont();
}