Remove CFX_FormatString::Release()

Avoid the |delete this| anti-pattern.
Remove some checks which don't avoid other segvs anyways.

Review-Url: https://codereview.chromium.org/2557173002

1 files changed, 1 insertions, 4 deletions

diff --git a/xfa/fgas/localization/fgas_localeimp.h b/xfa/fgas/localization/fgas_localeimp.h
index 66f1767c5c..7389158798 100644
--- a/xfa/fgas/localization/fgas_localeimp.h
+++ b/xfa/fgas/localization/fgas_localeimp.h
@@ -14,8 +14,7 @@ class CFX_LCNumeric;
 class CFX_FormatString {
  public:
   CFX_FormatString(IFX_LocaleMgr* pLocaleMgr, bool bUseLCID);
-
-  void Release() { delete this; }
+  ~CFX_FormatString();
 
   void SplitFormatString(const CFX_WideString& wsFormatString,
                          CFX_WideStringArray& wsPatterns);
@@ -62,8 +61,6 @@ class CFX_FormatString {
   bool FormatNull(const CFX_WideString& wsPattern, CFX_WideString& wsOutput);
 
  protected:
-  ~CFX_FormatString();
-
   IFX_Locale* GetTextFormat(const CFX_WideString& wsPattern,
                             const CFX_WideStringC& wsCategory,
                             CFX_WideString& wsPurgePattern);