summaryrefslogtreecommitdiff
path: root/xfa/fgas/localization
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-12-07 16:01:54 -0800
committerCommit bot <commit-bot@chromium.org>2016-12-07 16:01:54 -0800
commit248cb27e64b3a25230f53fc2f4ab9d483facc5f9 (patch)
tree50ba031ed7f77e20fa6a07c70d047f11d038c00c /xfa/fgas/localization
parenta9d29df6a774737a661d0f37f6b8aa5cba179c06 (diff)
downloadpdfium-248cb27e64b3a25230f53fc2f4ab9d483facc5f9.tar.xz
Remove CFX_FormatString::Release()
Avoid the |delete this| anti-pattern. Remove some checks which don't avoid other segvs anyways. Review-Url: https://codereview.chromium.org/2557173002
Diffstat (limited to 'xfa/fgas/localization')
-rw-r--r--xfa/fgas/localization/fgas_localeimp.h5
1 files changed, 1 insertions, 4 deletions
diff --git a/xfa/fgas/localization/fgas_localeimp.h b/xfa/fgas/localization/fgas_localeimp.h
index 66f1767c5c..7389158798 100644
--- a/xfa/fgas/localization/fgas_localeimp.h
+++ b/xfa/fgas/localization/fgas_localeimp.h
@@ -14,8 +14,7 @@ class CFX_LCNumeric;
class CFX_FormatString {
public:
CFX_FormatString(IFX_LocaleMgr* pLocaleMgr, bool bUseLCID);
-
- void Release() { delete this; }
+ ~CFX_FormatString();
void SplitFormatString(const CFX_WideString& wsFormatString,
CFX_WideStringArray& wsPatterns);
@@ -62,8 +61,6 @@ class CFX_FormatString {
bool FormatNull(const CFX_WideString& wsPattern, CFX_WideString& wsOutput);
protected:
- ~CFX_FormatString();
-
IFX_Locale* GetTextFormat(const CFX_WideString& wsPattern,
const CFX_WideStringC& wsCategory,
CFX_WideString& wsPurgePattern);