diff options
author | Dan Sinclair <dsinclair@chromium.org> | 2016-11-21 13:50:32 -0500 |
---|---|---|
committer | dan sinclair <dsinclair@chromium.org> | 2016-11-21 18:51:10 +0000 |
commit | 85c8e7f788512ce5b5b43cd816e8091b57c3d5e7 (patch) | |
tree | e727d747684b9db2632ef250b55046cfce2b55a3 /xfa/fgas/localization | |
parent | 7daa6fb286d1b5d65f99521f3314083e86d93e3f (diff) | |
download | pdfium-85c8e7f788512ce5b5b43cd816e8091b57c3d5e7.tar.xz |
Fixup lint flags.
The -build/include setting was masking out build/include_what_you_use. This CL
restores them, fixes any build errors, and adds NOLINT as needed. As well,
the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd.
lint cleanups
Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f
Reviewed-on: https://pdfium-review.googlesource.com/2030
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fgas/localization')
-rw-r--r-- | xfa/fgas/localization/fgas_datetime.h | 4 | ||||
-rw-r--r-- | xfa/fgas/localization/fgas_locale.cpp | 8 | ||||
-rw-r--r-- | xfa/fgas/localization/fgas_locale.h | 16 |
3 files changed, 16 insertions, 12 deletions
diff --git a/xfa/fgas/localization/fgas_datetime.h b/xfa/fgas/localization/fgas_datetime.h index 3383d45669..d3ea9fa4a6 100644 --- a/xfa/fgas/localization/fgas_datetime.h +++ b/xfa/fgas/localization/fgas_datetime.h @@ -30,7 +30,7 @@ uint8_t FX_DaysInMonth(int32_t iYear, uint8_t iMonth); class CFX_Unitime { public: CFX_Unitime() { m_iUnitime = 0; } - CFX_Unitime(FX_UNITIME iUnitime) { m_iUnitime = iUnitime; } + explicit CFX_Unitime(FX_UNITIME iUnitime) { m_iUnitime = iUnitime; } CFX_Unitime(const CFX_Unitime& unitime) { m_iUnitime = unitime.m_iUnitime; } operator FX_UNITIME*() { return &m_iUnitime; } operator FX_UNITIME const*() const { return &m_iUnitime; } @@ -212,7 +212,7 @@ struct FX_DATETIME { class CFX_DateTime { public: CFX_DateTime() {} - CFX_DateTime(const FX_DATETIME& dt) { m_DateTime = dt; } + explicit CFX_DateTime(const FX_DATETIME& dt) { m_DateTime = dt; } CFX_DateTime(const CFX_DateTime& dt) { m_DateTime = dt.m_DateTime; } virtual ~CFX_DateTime() {} operator FX_DATETIME*() { return &m_DateTime; } diff --git a/xfa/fgas/localization/fgas_locale.cpp b/xfa/fgas/localization/fgas_locale.cpp index 68fd94e29f..aea7bacc11 100644 --- a/xfa/fgas/localization/fgas_locale.cpp +++ b/xfa/fgas/localization/fgas_locale.cpp @@ -4,6 +4,8 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com +#include "xfa/fgas/localization/fgas_locale.h" + #include <algorithm> #include "core/fxcrt/fx_ext.h" @@ -92,9 +94,9 @@ class CFX_LCNumeric { CFX_LCNumeric(int64_t integral, uint32_t fractional = 0, int32_t exponent = 0); - CFX_LCNumeric(FX_FLOAT dbRetValue); - CFX_LCNumeric(double dbvalue); - CFX_LCNumeric(CFX_WideString& wsNumeric); + explicit CFX_LCNumeric(FX_FLOAT dbRetValue); + explicit CFX_LCNumeric(double dbvalue); + explicit CFX_LCNumeric(CFX_WideString& wsNumeric); FX_FLOAT GetFloat() const; double GetDouble() const; diff --git a/xfa/fgas/localization/fgas_locale.h b/xfa/fgas/localization/fgas_locale.h index a3272b455f..f15766d2dd 100644 --- a/xfa/fgas/localization/fgas_locale.h +++ b/xfa/fgas/localization/fgas_locale.h @@ -7,6 +7,8 @@ #ifndef XFA_FGAS_LOCALIZATION_FGAS_LOCALE_H_ #define XFA_FGAS_LOCALIZATION_FGAS_LOCALE_H_ +#include <memory> + #include "core/fxcrt/fx_xml.h" #include "xfa/fgas/localization/fgas_datetime.h" @@ -97,13 +99,13 @@ bool FX_TimeFromCanonical(const CFX_WideStringC& wsTime, class CFX_Decimal { public: CFX_Decimal(); - CFX_Decimal(uint32_t val); - CFX_Decimal(uint64_t val); - CFX_Decimal(int32_t val); - CFX_Decimal(int64_t val); - CFX_Decimal(FX_FLOAT val, uint8_t scale = 3); - CFX_Decimal(const CFX_WideStringC& str); - CFX_Decimal(const CFX_ByteStringC& str); + explicit CFX_Decimal(uint32_t val); + explicit CFX_Decimal(uint64_t val); + explicit CFX_Decimal(int32_t val); + explicit CFX_Decimal(int64_t val); + explicit CFX_Decimal(FX_FLOAT val, uint8_t scale = 3); + explicit CFX_Decimal(const CFX_WideStringC& str); + explicit CFX_Decimal(const CFX_ByteStringC& str); operator CFX_WideString() const; operator double() const; bool operator==(const CFX_Decimal& val) const; |