diff options
| author | dsinclair <dsinclair@chromium.org> | 2016-11-10 09:40:14 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-11-10 09:40:14 -0800 |
| commit | 98329fe75b9c3e5422344a37d787fb22c89c2ca2 (patch) | |
| tree | a1e7f3d35bc97695b074756ab7ef531c17c6262d /xfa/fwl/core/cfwl_combobox.h | |
| parent | 50feafc7f367a87b7e4e689421eb7ae1484660d9 (diff) | |
| download | pdfium-98329fe75b9c3e5422344a37d787fb22c89c2ca2.tar.xz | |
Cleanup IFWL_Widget visibility and virtual parameters
This Cl cleans up the IFWL_Widget class including:
* Making members and methods private where possible
* Removing virtual methods that are never overridden
* Removing methods that do nothing
* Removing unchecked FWL_Error return codes
Review-Url: https://codereview.chromium.org/2488953003
Diffstat (limited to 'xfa/fwl/core/cfwl_combobox.h')
| -rw-r--r-- | xfa/fwl/core/cfwl_combobox.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/xfa/fwl/core/cfwl_combobox.h b/xfa/fwl/core/cfwl_combobox.h index 4b544b4530..e2d35d24b5 100644 --- a/xfa/fwl/core/cfwl_combobox.h +++ b/xfa/fwl/core/cfwl_combobox.h @@ -28,7 +28,7 @@ class CFWL_ComboBox : public CFWL_Widget, public IFWL_ComboBoxDP { FWL_Error GetTextByIndex(int32_t iIndex, CFX_WideString& wsText); int32_t GetCurSel(); FWL_Error SetCurSel(int32_t iSel); - FWL_Error SetEditText(const CFX_WideString& wsText); + void SetEditText(const CFX_WideString& wsText); int32_t GetEditTextLength() const; FWL_Error GetEditText(CFX_WideString& wsText, int32_t nStart = 0, @@ -43,7 +43,7 @@ class CFWL_ComboBox : public CFWL_Widget, public IFWL_ComboBoxDP { FWL_Error SetMaxListHeight(FX_FLOAT fMaxHeight); FWL_Error SetItemData(int32_t iIndex, void* pData); void* GetItemData(int32_t iIndex); - FWL_Error SetListTheme(IFWL_ThemeProvider* pTheme); + void SetListTheme(IFWL_ThemeProvider* pTheme); bool AfterFocusShowDropList(); FWL_Error OpenDropDownList(bool bActivate); @@ -61,8 +61,7 @@ class CFWL_ComboBox : public CFWL_Widget, public IFWL_ComboBoxDP { bool EditDelete(); bool EditDeSelect(); FWL_Error GetBBox(CFX_RectF& rect); - FWL_Error EditModifyStylesEx(uint32_t dwStylesExAdded, - uint32_t dwStylesExRemoved); + void EditModifyStylesEx(uint32_t dwStylesExAdded, uint32_t dwStylesExRemoved); // IFWL_DataProvider FWL_Error GetCaption(IFWL_Widget* pWidget, |