summaryrefslogtreecommitdiff
path: root/xfa/fwl/core/cfwl_combobox.h
diff options
context:
space:
mode:
authordsinclair <dsinclair@chromium.org>2016-12-07 18:10:16 -0800
committerCommit bot <commit-bot@chromium.org>2016-12-07 18:10:16 -0800
commita2cbc570a035186529be151af0b3d44cf4106eee (patch)
tree1fbe99b81299839ff9c304739a85151d20c626b3 /xfa/fwl/core/cfwl_combobox.h
parent442997cbb3a9e970946dd294acd1498e9fa9bfc7 (diff)
downloadpdfium-a2cbc570a035186529be151af0b3d44cf4106eee.tar.xz
Cleanup return values in CFWL_ComboBox
This CL changes methods in CFWL_ComboBox to return values instead of taking out params. Review-Url: https://codereview.chromium.org/2555103005
Diffstat (limited to 'xfa/fwl/core/cfwl_combobox.h')
-rw-r--r--xfa/fwl/core/cfwl_combobox.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/xfa/fwl/core/cfwl_combobox.h b/xfa/fwl/core/cfwl_combobox.h
index 812a6d0a29..b10a571b2c 100644
--- a/xfa/fwl/core/cfwl_combobox.h
+++ b/xfa/fwl/core/cfwl_combobox.h
@@ -68,7 +68,7 @@ class CFWL_ComboBox : public CFWL_Widget {
void OnDrawWidget(CFX_Graphics* pGraphics,
const CFX_Matrix* pMatrix) override;
- void GetTextByIndex(int32_t iIndex, CFX_WideString& wsText) const;
+ CFX_WideString GetTextByIndex(int32_t iIndex) const;
int32_t GetCurSel() const { return m_iCurSel; }
void SetCurSel(int32_t iSel);
@@ -101,7 +101,7 @@ class CFWL_ComboBox : public CFWL_Widget {
void EditDelete() { m_pEdit->ClearText(); }
void EditDeSelect() { m_pEdit->ClearSelections(); }
- void GetBBox(CFX_RectF& rect) const;
+ CFX_RectF GetBBox() const;
void EditModifyStylesEx(uint32_t dwStylesExAdded, uint32_t dwStylesExRemoved);
void DrawStretchHandler(CFX_Graphics* pGraphics, const CFX_Matrix* pMatrix);
@@ -146,7 +146,7 @@ class CFWL_ComboBox : public CFWL_Widget {
void DisForm_Update();
FWL_WidgetHit DisForm_HitTest(FX_FLOAT fx, FX_FLOAT fy);
void DisForm_DrawWidget(CFX_Graphics* pGraphics, const CFX_Matrix* pMatrix);
- void DisForm_GetBBox(CFX_RectF& rect) const;
+ CFX_RectF DisForm_GetBBox() const;
void DisForm_Layout();
void DisForm_OnProcessMessage(CFWL_Message* pMessage);
void DisForm_OnLButtonDown(CFWL_MsgMouse* pMsg);