diff options
| author | Ryan Harrison <rharrison@chromium.org> | 2017-07-28 14:07:04 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-07-28 18:21:44 +0000 |
| commit | e7a99de4f711302d57fe22682a9a8c3cfddb458c (patch) | |
| tree | 7bb176d42e2a2181f014b41bd621d6b242ed20e7 /xfa/fwl | |
| parent | 106eecd27f346a0bc7f11f29a058a8fd16a77682 (diff) | |
| download | pdfium-e7a99de4f711302d57fe22682a9a8c3cfddb458c.tar.xz | |
Convert calls to Mid() to Left() or Right() if possible
The various string/byte classes support Mid(), Left(), and Right() for
extracting substrings. Mid() can handle all possible cases, but Left()
and Right() are useful for common cases and more explicit about what
is going on.
Calls like Mid(offset, length - offset) can be converted to
Right(length - offset). Calls like Mid(0, length) can be converted to
Left(length).
If the substring being extracted does not extend all the way to one of
the edges of the string, then Mid() still needs to be used.
BUG=pdfium:828
Change-Id: I2ec46ad3d71aac0f7b513e103c69cbe8c854cf62
Reviewed-on: https://pdfium-review.googlesource.com/9510
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fwl')
| -rw-r--r-- | xfa/fwl/cfwl_edit.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xfa/fwl/cfwl_edit.cpp b/xfa/fwl/cfwl_edit.cpp index 12786496d4..53fec0576e 100644 --- a/xfa/fwl/cfwl_edit.cpp +++ b/xfa/fwl/cfwl_edit.cpp @@ -1152,8 +1152,8 @@ bool CFWL_Edit::ValidateNumberChar(wchar_t cNum) { return false; int32_t nLen = wsText.GetLength(); - CFX_WideString l = wsText.Mid(0, caretPos); - CFX_WideString r = wsText.Mid(caretPos, nLen - caretPos); + CFX_WideString l = wsText.Left(caretPos); + CFX_WideString r = wsText.Right(nLen - caretPos); CFX_WideString wsNew = l + cNum + r; return wsNew.GetInteger() <= m_iMax; } |