diff options
author | Tom Sepez <tsepez@chromium.org> | 2018-08-27 20:18:04 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-08-27 20:18:04 +0000 |
commit | 55865454c43fbc3b163cff166544ba0a060dcbc4 (patch) | |
tree | 66cefeed22a38d19db07e63b315c9f09832d11b2 /xfa/fwl | |
parent | 76525c4a9d2aa6d1f2685d8483e3d491fd361df1 (diff) | |
download | pdfium-55865454c43fbc3b163cff166544ba0a060dcbc4.tar.xz |
The final game: mark everything final.
Then revert the ones that break compilation.
Fix one IWYU noticed during presubmit.
Change-Id: I881a8a72818e55dbc4816247e35ff5e3015194e7
Reviewed-on: https://pdfium-review.googlesource.com/41470
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fwl')
36 files changed, 38 insertions, 38 deletions
diff --git a/xfa/fwl/cfwl_barcode.h b/xfa/fwl/cfwl_barcode.h index a4991d4cf7..cd36cc3e41 100644 --- a/xfa/fwl/cfwl_barcode.h +++ b/xfa/fwl/cfwl_barcode.h @@ -36,7 +36,7 @@ enum FWL_BCDAttribute { FWL_BCDATTRIBUTE_ECLEVEL = 1 << 10, }; -class CFWL_Barcode : public CFWL_Edit { +class CFWL_Barcode final : public CFWL_Edit { public: explicit CFWL_Barcode(const CFWL_App* pApp); ~CFWL_Barcode() override; diff --git a/xfa/fwl/cfwl_caret.h b/xfa/fwl/cfwl_caret.h index 90d62d6e9b..88bec752cc 100644 --- a/xfa/fwl/cfwl_caret.h +++ b/xfa/fwl/cfwl_caret.h @@ -16,7 +16,7 @@ class CFWL_WidgetProperties; class CFWL_Widget; -class CFWL_Caret : public CFWL_Widget { +class CFWL_Caret final : public CFWL_Widget { public: CFWL_Caret(const CFWL_App* app, std::unique_ptr<CFWL_WidgetProperties> properties, @@ -35,7 +35,7 @@ class CFWL_Caret : public CFWL_Widget { void HideCaret(); private: - class Timer : public CFWL_Timer { + class Timer final : public CFWL_Timer { public: explicit Timer(CFWL_Caret* pCaret); ~Timer() override {} diff --git a/xfa/fwl/cfwl_checkbox.h b/xfa/fwl/cfwl_checkbox.h index 9ae6590b2f..f2413aaca7 100644 --- a/xfa/fwl/cfwl_checkbox.h +++ b/xfa/fwl/cfwl_checkbox.h @@ -33,7 +33,7 @@ class CFWL_MessageMouse; class CFWL_WidgetProperties; class CFWL_Widget; -class CFWL_CheckBox : public CFWL_Widget { +class CFWL_CheckBox final : public CFWL_Widget { public: explicit CFWL_CheckBox(const CFWL_App* pApp); ~CFWL_CheckBox() override; diff --git a/xfa/fwl/cfwl_combobox.h b/xfa/fwl/cfwl_combobox.h index a5ea2d0876..f247d93ddb 100644 --- a/xfa/fwl/cfwl_combobox.h +++ b/xfa/fwl/cfwl_combobox.h @@ -36,7 +36,7 @@ class CFWL_Widget; #define FWL_STYLEEXT_CMB_ListItemAlignMask (3L << 10) #define FWL_STYLEEXT_CMB_ReadOnly (1L << 13) -class CFWL_ComboBox : public CFWL_Widget { +class CFWL_ComboBox final : public CFWL_Widget { public: explicit CFWL_ComboBox(const CFWL_App* pApp); ~CFWL_ComboBox() override; diff --git a/xfa/fwl/cfwl_comboedit.h b/xfa/fwl/cfwl_comboedit.h index efdabd3669..daaa8a95cb 100644 --- a/xfa/fwl/cfwl_comboedit.h +++ b/xfa/fwl/cfwl_comboedit.h @@ -15,7 +15,7 @@ class CFWL_ComboBox; -class CFWL_ComboEdit : public CFWL_Edit { +class CFWL_ComboEdit final : public CFWL_Edit { public: CFWL_ComboEdit(const CFWL_App* app, std::unique_ptr<CFWL_WidgetProperties> properties, diff --git a/xfa/fwl/cfwl_combolist.h b/xfa/fwl/cfwl_combolist.h index a4d513559e..0444a93c21 100644 --- a/xfa/fwl/cfwl_combolist.h +++ b/xfa/fwl/cfwl_combolist.h @@ -13,7 +13,7 @@ #include "xfa/fwl/cfwl_widget.h" #include "xfa/fwl/cfwl_widgetproperties.h" -class CFWL_ComboList : public CFWL_ListBox { +class CFWL_ComboList final : public CFWL_ListBox { public: CFWL_ComboList(const CFWL_App* app, std::unique_ptr<CFWL_WidgetProperties> properties, diff --git a/xfa/fwl/cfwl_datetimeedit.h b/xfa/fwl/cfwl_datetimeedit.h index dcbebd2027..cc80b9e8ba 100644 --- a/xfa/fwl/cfwl_datetimeedit.h +++ b/xfa/fwl/cfwl_datetimeedit.h @@ -13,7 +13,7 @@ #include "xfa/fwl/cfwl_widget.h" #include "xfa/fwl/cfwl_widgetproperties.h" -class CFWL_DateTimeEdit : public CFWL_Edit { +class CFWL_DateTimeEdit final : public CFWL_Edit { public: CFWL_DateTimeEdit(const CFWL_App* app, std::unique_ptr<CFWL_WidgetProperties> properties, diff --git a/xfa/fwl/cfwl_datetimepicker.h b/xfa/fwl/cfwl_datetimepicker.h index f80f09d1bf..8e05ddecb1 100644 --- a/xfa/fwl/cfwl_datetimepicker.h +++ b/xfa/fwl/cfwl_datetimepicker.h @@ -30,7 +30,7 @@ class CFWL_DateTimeEdit; -class CFWL_DateTimePicker : public CFWL_Widget { +class CFWL_DateTimePicker final : public CFWL_Widget { public: explicit CFWL_DateTimePicker(const CFWL_App* pApp); ~CFWL_DateTimePicker() override; diff --git a/xfa/fwl/cfwl_eventmouse.h b/xfa/fwl/cfwl_eventmouse.h index a5caa93959..170f39af4e 100644 --- a/xfa/fwl/cfwl_eventmouse.h +++ b/xfa/fwl/cfwl_eventmouse.h @@ -9,7 +9,7 @@ #include "xfa/fwl/cfwl_event.h" -class CFWL_EventMouse : public CFWL_Event { +class CFWL_EventMouse final : public CFWL_Event { public: explicit CFWL_EventMouse(CFWL_Widget* pSrcTarget); CFWL_EventMouse(CFWL_Widget* pSrcTarget, CFWL_Widget* pDstTarget); diff --git a/xfa/fwl/cfwl_eventscroll.h b/xfa/fwl/cfwl_eventscroll.h index a13eeef020..0491ad71ea 100644 --- a/xfa/fwl/cfwl_eventscroll.h +++ b/xfa/fwl/cfwl_eventscroll.h @@ -9,7 +9,7 @@ #include "xfa/fwl/cfwl_event.h" -class CFWL_EventScroll : public CFWL_Event { +class CFWL_EventScroll final : public CFWL_Event { public: enum class Code { None = 1, diff --git a/xfa/fwl/cfwl_eventselectchanged.h b/xfa/fwl/cfwl_eventselectchanged.h index 30f1e2d5c7..176cb8713b 100644 --- a/xfa/fwl/cfwl_eventselectchanged.h +++ b/xfa/fwl/cfwl_eventselectchanged.h @@ -9,7 +9,7 @@ #include "xfa/fwl/cfwl_event.h" -class CFWL_EventSelectChanged : public CFWL_Event { +class CFWL_EventSelectChanged final : public CFWL_Event { public: explicit CFWL_EventSelectChanged(CFWL_Widget* pSrcTarget); ~CFWL_EventSelectChanged() override; diff --git a/xfa/fwl/cfwl_eventtextwillchange.h b/xfa/fwl/cfwl_eventtextwillchange.h index 4b2781f0d1..a1bfe8cdec 100644 --- a/xfa/fwl/cfwl_eventtextwillchange.h +++ b/xfa/fwl/cfwl_eventtextwillchange.h @@ -9,7 +9,7 @@ #include "xfa/fwl/cfwl_event.h" -class CFWL_EventTextWillChange : public CFWL_Event { +class CFWL_EventTextWillChange final : public CFWL_Event { public: explicit CFWL_EventTextWillChange(CFWL_Widget* pSrcTarget); ~CFWL_EventTextWillChange() override; diff --git a/xfa/fwl/cfwl_eventvalidate.h b/xfa/fwl/cfwl_eventvalidate.h index b8feff1120..7d88b97bb5 100644 --- a/xfa/fwl/cfwl_eventvalidate.h +++ b/xfa/fwl/cfwl_eventvalidate.h @@ -9,7 +9,7 @@ #include "xfa/fwl/cfwl_event.h" -class CFWL_EventValidate : public CFWL_Event { +class CFWL_EventValidate final : public CFWL_Event { public: explicit CFWL_EventValidate(CFWL_Widget* pSrcTarget); ~CFWL_EventValidate() override; diff --git a/xfa/fwl/cfwl_form.h b/xfa/fwl/cfwl_form.h index 01ae9be5c0..4e13001283 100644 --- a/xfa/fwl/cfwl_form.h +++ b/xfa/fwl/cfwl_form.h @@ -20,7 +20,7 @@ class CFWL_NoteLoop; class CFWL_Widget; class IFWL_ThemeProvider; -class CFWL_Form : public CFWL_Widget { +class CFWL_Form final : public CFWL_Widget { public: CFWL_Form(const CFWL_App* app, std::unique_ptr<CFWL_WidgetProperties> properties, diff --git a/xfa/fwl/cfwl_messagekey.h b/xfa/fwl/cfwl_messagekey.h index bf430d3ba5..183577470d 100644 --- a/xfa/fwl/cfwl_messagekey.h +++ b/xfa/fwl/cfwl_messagekey.h @@ -13,7 +13,7 @@ enum class FWL_KeyCommand { KeyDown, KeyUp, Char }; -class CFWL_MessageKey : public CFWL_Message { +class CFWL_MessageKey final : public CFWL_Message { public: CFWL_MessageKey(CFWL_Widget* pSrcTarget, CFWL_Widget* pDstTarget); ~CFWL_MessageKey() override; diff --git a/xfa/fwl/cfwl_messagekillfocus.h b/xfa/fwl/cfwl_messagekillfocus.h index 79aaebed6c..56cfc399b5 100644 --- a/xfa/fwl/cfwl_messagekillfocus.h +++ b/xfa/fwl/cfwl_messagekillfocus.h @@ -12,7 +12,7 @@ #include "core/fxcrt/unowned_ptr.h" #include "xfa/fwl/cfwl_message.h" -class CFWL_MessageKillFocus : public CFWL_Message { +class CFWL_MessageKillFocus final : public CFWL_Message { public: explicit CFWL_MessageKillFocus(CFWL_Widget* pSrcTarget); CFWL_MessageKillFocus(CFWL_Widget* pSrcTarget, CFWL_Widget* pDstTarget); diff --git a/xfa/fwl/cfwl_messagemouse.h b/xfa/fwl/cfwl_messagemouse.h index a2b0d39ae0..ae9711f17c 100644 --- a/xfa/fwl/cfwl_messagemouse.h +++ b/xfa/fwl/cfwl_messagemouse.h @@ -25,7 +25,7 @@ enum class FWL_MouseCommand { Hover }; -class CFWL_MessageMouse : public CFWL_Message { +class CFWL_MessageMouse final : public CFWL_Message { public: CFWL_MessageMouse(CFWL_Widget* pSrcTarget, CFWL_Widget* pDstTarget); CFWL_MessageMouse(const CFWL_MessageMouse& other); diff --git a/xfa/fwl/cfwl_messagemousewheel.h b/xfa/fwl/cfwl_messagemousewheel.h index f969b9a8f3..8fc3a63327 100644 --- a/xfa/fwl/cfwl_messagemousewheel.h +++ b/xfa/fwl/cfwl_messagemousewheel.h @@ -12,7 +12,7 @@ #include "core/fxcrt/fx_coordinates.h" #include "xfa/fwl/cfwl_message.h" -class CFWL_MessageMouseWheel : public CFWL_Message { +class CFWL_MessageMouseWheel final : public CFWL_Message { public: CFWL_MessageMouseWheel(CFWL_Widget* pSrcTarget, CFWL_Widget* pDstTarget); CFWL_MessageMouseWheel(const CFWL_MessageMouseWheel&); diff --git a/xfa/fwl/cfwl_messagesetfocus.h b/xfa/fwl/cfwl_messagesetfocus.h index 05616fbe2e..b9f0f0fb27 100644 --- a/xfa/fwl/cfwl_messagesetfocus.h +++ b/xfa/fwl/cfwl_messagesetfocus.h @@ -11,7 +11,7 @@ #include "xfa/fwl/cfwl_message.h" -class CFWL_MessageSetFocus : public CFWL_Message { +class CFWL_MessageSetFocus final : public CFWL_Message { public: CFWL_MessageSetFocus(CFWL_Widget* pSrcTarget, CFWL_Widget* pDstTarget); ~CFWL_MessageSetFocus() override; diff --git a/xfa/fwl/cfwl_monthcalendar.h b/xfa/fwl/cfwl_monthcalendar.h index bdf66a0b5c..1bb0bd27bc 100644 --- a/xfa/fwl/cfwl_monthcalendar.h +++ b/xfa/fwl/cfwl_monthcalendar.h @@ -20,7 +20,7 @@ class CFWL_MessageMouse; -class CFWL_MonthCalendar : public CFWL_Widget { +class CFWL_MonthCalendar final : public CFWL_Widget { public: CFWL_MonthCalendar(const CFWL_App* app, std::unique_ptr<CFWL_WidgetProperties> properties, diff --git a/xfa/fwl/cfwl_picturebox.h b/xfa/fwl/cfwl_picturebox.h index 363db8a291..3823a5990b 100644 --- a/xfa/fwl/cfwl_picturebox.h +++ b/xfa/fwl/cfwl_picturebox.h @@ -15,7 +15,7 @@ class CFX_DIBitmap; class CFWL_Widget; -class CFWL_PictureBox : public CFWL_Widget { +class CFWL_PictureBox final : public CFWL_Widget { public: explicit CFWL_PictureBox(const CFWL_App* pApp); ~CFWL_PictureBox() override; diff --git a/xfa/fwl/cfwl_pushbutton.h b/xfa/fwl/cfwl_pushbutton.h index 5c509fb503..275f9b5ea3 100644 --- a/xfa/fwl/cfwl_pushbutton.h +++ b/xfa/fwl/cfwl_pushbutton.h @@ -19,7 +19,7 @@ class CFWL_MessageMouse; class CFX_DIBitmap; class CFWL_Widget; -class CFWL_PushButton : public CFWL_Widget { +class CFWL_PushButton final : public CFWL_Widget { public: explicit CFWL_PushButton(const CFWL_App*); ~CFWL_PushButton() override; diff --git a/xfa/fwl/cfwl_scrollbar.h b/xfa/fwl/cfwl_scrollbar.h index de394ed96d..fc5248fbf7 100644 --- a/xfa/fwl/cfwl_scrollbar.h +++ b/xfa/fwl/cfwl_scrollbar.h @@ -21,7 +21,7 @@ class CFWL_Widget; #define FWL_STYLEEXT_SCB_Horz (0L << 0) #define FWL_STYLEEXT_SCB_Vert (1L << 0) -class CFWL_ScrollBar : public CFWL_Widget { +class CFWL_ScrollBar final : public CFWL_Widget { public: CFWL_ScrollBar(const CFWL_App* app, std::unique_ptr<CFWL_WidgetProperties> properties, @@ -55,7 +55,7 @@ class CFWL_ScrollBar : public CFWL_Widget { void SetTrackPos(float fTrackPos); private: - class Timer : public CFWL_Timer { + class Timer final : public CFWL_Timer { public: explicit Timer(CFWL_ScrollBar* pToolTip); ~Timer() override {} diff --git a/xfa/fwl/cfwl_themebackground.h b/xfa/fwl/cfwl_themebackground.h index 37103ae01a..46df73c8bf 100644 --- a/xfa/fwl/cfwl_themebackground.h +++ b/xfa/fwl/cfwl_themebackground.h @@ -13,7 +13,7 @@ class CXFA_Graphics; class CXFA_GEPath; -class CFWL_ThemeBackground : public CFWL_ThemePart { +class CFWL_ThemeBackground final : public CFWL_ThemePart { public: CFWL_ThemeBackground(); ~CFWL_ThemeBackground(); diff --git a/xfa/fwl/cfwl_themetext.h b/xfa/fwl/cfwl_themetext.h index 91a3f385df..a63b8bf040 100644 --- a/xfa/fwl/cfwl_themetext.h +++ b/xfa/fwl/cfwl_themetext.h @@ -11,7 +11,7 @@ #include "core/fxcrt/fx_system.h" #include "xfa/fwl/cfwl_themepart.h" -class CFWL_ThemeText : public CFWL_ThemePart { +class CFWL_ThemeText final : public CFWL_ThemePart { public: CFWL_ThemeText() : m_pGraphics(nullptr) {} diff --git a/xfa/fwl/theme/cfwl_barcodetp.h b/xfa/fwl/theme/cfwl_barcodetp.h index 42b41e7d42..3fb9d3d9fd 100644 --- a/xfa/fwl/theme/cfwl_barcodetp.h +++ b/xfa/fwl/theme/cfwl_barcodetp.h @@ -10,7 +10,7 @@ #include "xfa/fwl/theme/cfwl_utils.h" #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_BarcodeTP : public CFWL_WidgetTP { +class CFWL_BarcodeTP final : public CFWL_WidgetTP { public: CFWL_BarcodeTP(); ~CFWL_BarcodeTP() override; diff --git a/xfa/fwl/theme/cfwl_carettp.h b/xfa/fwl/theme/cfwl_carettp.h index 64bf51b20a..a71afc935f 100644 --- a/xfa/fwl/theme/cfwl_carettp.h +++ b/xfa/fwl/theme/cfwl_carettp.h @@ -9,7 +9,7 @@ #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_CaretTP : public CFWL_WidgetTP { +class CFWL_CaretTP final : public CFWL_WidgetTP { public: CFWL_CaretTP(); ~CFWL_CaretTP() override; diff --git a/xfa/fwl/theme/cfwl_checkboxtp.h b/xfa/fwl/theme/cfwl_checkboxtp.h index c4341edf60..fa06c7ec0e 100644 --- a/xfa/fwl/theme/cfwl_checkboxtp.h +++ b/xfa/fwl/theme/cfwl_checkboxtp.h @@ -12,7 +12,7 @@ #include "xfa/fwl/theme/cfwl_utils.h" #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_CheckBoxTP : public CFWL_WidgetTP { +class CFWL_CheckBoxTP final : public CFWL_WidgetTP { public: CFWL_CheckBoxTP(); ~CFWL_CheckBoxTP() override; diff --git a/xfa/fwl/theme/cfwl_comboboxtp.h b/xfa/fwl/theme/cfwl_comboboxtp.h index 183d3a0743..dd8311c8a1 100644 --- a/xfa/fwl/theme/cfwl_comboboxtp.h +++ b/xfa/fwl/theme/cfwl_comboboxtp.h @@ -9,7 +9,7 @@ #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_ComboBoxTP : public CFWL_WidgetTP { +class CFWL_ComboBoxTP final : public CFWL_WidgetTP { public: CFWL_ComboBoxTP(); ~CFWL_ComboBoxTP() override; diff --git a/xfa/fwl/theme/cfwl_datetimepickertp.h b/xfa/fwl/theme/cfwl_datetimepickertp.h index 11536a390c..5a548511cf 100644 --- a/xfa/fwl/theme/cfwl_datetimepickertp.h +++ b/xfa/fwl/theme/cfwl_datetimepickertp.h @@ -9,7 +9,7 @@ #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_DateTimePickerTP : public CFWL_WidgetTP { +class CFWL_DateTimePickerTP final : public CFWL_WidgetTP { public: CFWL_DateTimePickerTP(); ~CFWL_DateTimePickerTP() override; diff --git a/xfa/fwl/theme/cfwl_edittp.h b/xfa/fwl/theme/cfwl_edittp.h index e1c6ac9242..7d005602e6 100644 --- a/xfa/fwl/theme/cfwl_edittp.h +++ b/xfa/fwl/theme/cfwl_edittp.h @@ -9,7 +9,7 @@ #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_EditTP : public CFWL_WidgetTP { +class CFWL_EditTP final : public CFWL_WidgetTP { public: CFWL_EditTP(); ~CFWL_EditTP() override; diff --git a/xfa/fwl/theme/cfwl_listboxtp.h b/xfa/fwl/theme/cfwl_listboxtp.h index cc4691cce0..95ce01c441 100644 --- a/xfa/fwl/theme/cfwl_listboxtp.h +++ b/xfa/fwl/theme/cfwl_listboxtp.h @@ -9,7 +9,7 @@ #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_ListBoxTP : public CFWL_WidgetTP { +class CFWL_ListBoxTP final : public CFWL_WidgetTP { public: CFWL_ListBoxTP(); ~CFWL_ListBoxTP() override; diff --git a/xfa/fwl/theme/cfwl_monthcalendartp.h b/xfa/fwl/theme/cfwl_monthcalendartp.h index 6a1b9be360..95e2a190b7 100644 --- a/xfa/fwl/theme/cfwl_monthcalendartp.h +++ b/xfa/fwl/theme/cfwl_monthcalendartp.h @@ -11,7 +11,7 @@ #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_MonthCalendarTP : public CFWL_WidgetTP { +class CFWL_MonthCalendarTP final : public CFWL_WidgetTP { public: CFWL_MonthCalendarTP(); ~CFWL_MonthCalendarTP() override; diff --git a/xfa/fwl/theme/cfwl_pictureboxtp.h b/xfa/fwl/theme/cfwl_pictureboxtp.h index 4a118f21f8..1bb3486c44 100644 --- a/xfa/fwl/theme/cfwl_pictureboxtp.h +++ b/xfa/fwl/theme/cfwl_pictureboxtp.h @@ -9,7 +9,7 @@ #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_PictureBoxTP : public CFWL_WidgetTP { +class CFWL_PictureBoxTP final : public CFWL_WidgetTP { public: CFWL_PictureBoxTP(); ~CFWL_PictureBoxTP() override; diff --git a/xfa/fwl/theme/cfwl_pushbuttontp.h b/xfa/fwl/theme/cfwl_pushbuttontp.h index b2372bb066..2e1782a1b5 100644 --- a/xfa/fwl/theme/cfwl_pushbuttontp.h +++ b/xfa/fwl/theme/cfwl_pushbuttontp.h @@ -11,7 +11,7 @@ #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_PushButtonTP : public CFWL_WidgetTP { +class CFWL_PushButtonTP final : public CFWL_WidgetTP { public: CFWL_PushButtonTP(); ~CFWL_PushButtonTP() override; diff --git a/xfa/fwl/theme/cfwl_scrollbartp.h b/xfa/fwl/theme/cfwl_scrollbartp.h index 8398706458..53cbb38d83 100644 --- a/xfa/fwl/theme/cfwl_scrollbartp.h +++ b/xfa/fwl/theme/cfwl_scrollbartp.h @@ -11,7 +11,7 @@ #include "xfa/fwl/theme/cfwl_widgettp.h" -class CFWL_ScrollBarTP : public CFWL_WidgetTP { +class CFWL_ScrollBarTP final : public CFWL_WidgetTP { public: CFWL_ScrollBarTP(); ~CFWL_ScrollBarTP() override; |