diff options
author | weili <weili@chromium.org> | 2016-06-14 18:20:04 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-06-14 18:20:04 -0700 |
commit | 29b8ad0b130ec6ed4f72ebd0c0a4f9e6a5b03467 (patch) | |
tree | d40c21b3396ad28de29640fcf759ca678203910f /xfa/fxbarcode/common/BC_CommonCharacterSetECI.h | |
parent | f4bb580add3824196dc49cd7de2f7d051019ede8 (diff) | |
download | pdfium-29b8ad0b130ec6ed4f72ebd0c0a4f9e6a5b03467.tar.xz |
Make code compile with clang_use_chrome_plugin (part III)
This change contains files in xfa/fxbarcode directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.
The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;
BUG=pdfium:469
Review-Url: https://codereview.chromium.org/2067903002
Diffstat (limited to 'xfa/fxbarcode/common/BC_CommonCharacterSetECI.h')
-rw-r--r-- | xfa/fxbarcode/common/BC_CommonCharacterSetECI.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xfa/fxbarcode/common/BC_CommonCharacterSetECI.h b/xfa/fxbarcode/common/BC_CommonCharacterSetECI.h index 5bd77e4fd1..a2fe0ed2fe 100644 --- a/xfa/fxbarcode/common/BC_CommonCharacterSetECI.h +++ b/xfa/fxbarcode/common/BC_CommonCharacterSetECI.h @@ -13,10 +13,10 @@ class CBC_CommonCharacterSetECI : public CBC_CommonECI { public: CBC_CommonCharacterSetECI(int32_t value, CFX_ByteString encodingName); - virtual ~CBC_CommonCharacterSetECI(); + ~CBC_CommonCharacterSetECI() override; + CFX_ByteString GetEncodingName(); static void AddCharacterSet(int32_t value, CFX_ByteString encodingName); - int32_t GetValue(); static CBC_CommonCharacterSetECI* GetCharacterSetECIByValue(int32_t value); static CBC_CommonCharacterSetECI* GetCharacterSetECIByName( const CFX_ByteString& name); |