Make code compile with clang_use_chrome_plugin (part III)

This change contains files in xfa/fxbarcode directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469

Review-Url: https://codereview.chromium.org/2067903002

1 files changed, 5 insertions, 6 deletions

diff --git a/xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.h b/xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.h
index 8ef053b334..d06b051554 100644
--- a/xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.h
+++ b/xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.h
@@ -19,12 +19,9 @@ class CBC_ResultPointsAndTransitions {
  public:
   CBC_ResultPointsAndTransitions(CBC_ResultPoint* from,
                                  CBC_ResultPoint* to,
-                                 int32_t transitions) {
-    m_from = from;
-    m_to = to;
-    m_transitions = transitions;
-  }
-  ~CBC_ResultPointsAndTransitions() {}
+                                 int32_t transitions);
+  ~CBC_ResultPointsAndTransitions();
+
   CBC_ResultPoint* GetFrom() const { return m_from; }
   CBC_ResultPoint* GetTo() const { return m_to; }
   int32_t GetTransitions() const { return m_transitions; }
@@ -39,6 +36,7 @@ class CBC_DataMatrixDetector {
  public:
   CBC_DataMatrixDetector(CBC_CommonBitMatrix* image);
   virtual ~CBC_DataMatrixDetector();
+
   CBC_QRDetectorResult* Detect(int32_t& e);
   CBC_ResultPoint* CorrectTopRightRectangular(CBC_ResultPoint* bottomLeft,
                                               CBC_ResultPoint* bottomRight,
@@ -67,6 +65,7 @@ class CBC_DataMatrixDetector {
                  CBC_ResultPoint* key);
   int32_t Round(FX_FLOAT d);
   void OrderBestPatterns(CFX_ArrayTemplate<CBC_ResultPoint*>* patterns);
+
   virtual void Init(int32_t& e);
 
  private: