diff options
| author | weili <weili@chromium.org> | 2016-05-23 10:38:07 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-05-23 10:38:07 -0700 |
| commit | 524fa626d71efeb2164c82d565f17f077035b7df (patch) | |
| tree | 0ad13752db2c216dced6872671db7ef179def4a0 /xfa/fxbarcode/datamatrix | |
| parent | 168fc2be3253fdfb8a58685b89d28a471fa4740a (diff) | |
| download | pdfium-524fa626d71efeb2164c82d565f17f077035b7df.tar.xz | |
Clean up more XFA code which causes warnings
This is part of efforts to bring XFA to chromium_code standard.
Most of them will have behavior change.
The details of these problems are:
xfa/fgas/layout/fgas_rtfbreak.cpp:
Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
xfa/fxfa/app/xfa_fffield.cpp
Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
Wrong condition logic
BUG=pdfium:29
Review-Url: https://codereview.chromium.org/2000073003
Diffstat (limited to 'xfa/fxbarcode/datamatrix')
| -rw-r--r-- | xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp b/xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp index 53c5a84656..292a1de2f7 100644 --- a/xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp +++ b/xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp @@ -246,7 +246,7 @@ void CBC_DataMatrixDecodedBitStreamParser::DecodeC40Segment( shift = 0; break; default: - break; + // Should never be reached. e = BCExceptionFormatException; return; } @@ -337,7 +337,7 @@ void CBC_DataMatrixDecodedBitStreamParser::DecodeTextSegment( } break; default: - break; + // Should never be reached. e = BCExceptionFormatException; return; } |