summaryrefslogtreecommitdiff
path: root/xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-04-04 16:41:35 -0700
committerCommit bot <commit-bot@chromium.org>2016-04-04 16:41:35 -0700
commit28f97ff783c16f3391384ce97b765ce4eb310ac7 (patch)
tree69c4c8bc9dd39d5336c96f28b633d197dd207c81 /xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp
parented9c4386713084f37548b46ab36f618021f716f5 (diff)
downloadpdfium-28f97ff783c16f3391384ce97b765ce4eb310ac7.tar.xz
Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.
Having this happen implicitly can be dangerous because the lifetime has to be considered; we should have caught the "red bots" in https://codereview.chromium.org/1847333004/#ps60001 at compile time. Review URL: https://codereview.chromium.org/1853233002
Diffstat (limited to 'xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp')
-rw-r--r--xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp b/xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp
index 5f8a0c25aa..f767ffa169 100644
--- a/xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp
+++ b/xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp
@@ -106,7 +106,8 @@ CFX_ByteString CBC_OnedCodaBarReader::DecodeRow(int32_t rowNumber,
}
}
if (result.GetLength() < 5) {
- int32_t index = temp.Find(result.Mid(1, result.GetLength() - 1));
+ int32_t index =
+ temp.Find(result.Mid(1, result.GetLength() - 1).AsByteStringC());
if (index == len - (result.GetLength() - 1)) {
e = BCExceptionNotFound;
return "";