diff options
| author | weili <weili@chromium.org> | 2016-06-14 18:20:04 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-06-14 18:20:04 -0700 |
| commit | 29b8ad0b130ec6ed4f72ebd0c0a4f9e6a5b03467 (patch) | |
| tree | d40c21b3396ad28de29640fcf759ca678203910f /xfa/fxbarcode/oned/BC_OnedUPCAReader.h | |
| parent | f4bb580add3824196dc49cd7de2f7d051019ede8 (diff) | |
| download | pdfium-29b8ad0b130ec6ed4f72ebd0c0a4f9e6a5b03467.tar.xz | |
Make code compile with clang_use_chrome_plugin (part III)
This change contains files in xfa/fxbarcode directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.
The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;
BUG=pdfium:469
Review-Url: https://codereview.chromium.org/2067903002
Diffstat (limited to 'xfa/fxbarcode/oned/BC_OnedUPCAReader.h')
| -rw-r--r-- | xfa/fxbarcode/oned/BC_OnedUPCAReader.h | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/xfa/fxbarcode/oned/BC_OnedUPCAReader.h b/xfa/fxbarcode/oned/BC_OnedUPCAReader.h index c073930c5b..28e03fc21f 100644 --- a/xfa/fxbarcode/oned/BC_OnedUPCAReader.h +++ b/xfa/fxbarcode/oned/BC_OnedUPCAReader.h @@ -18,27 +18,32 @@ class CBC_OnedEAN13Reader; class CBC_OnedUPCAReader : public CBC_OneDimReader { public: CBC_OnedUPCAReader(); - virtual ~CBC_OnedUPCAReader(); + ~CBC_OnedUPCAReader() override; virtual void Init(); + // CBC_OneDimReader CFX_ByteString DecodeRow(int32_t rowNumber, CBC_CommonBitArray* row, int32_t hints, - int32_t& e); + int32_t& e) override; CFX_ByteString DecodeRow(int32_t rowNumber, CBC_CommonBitArray* row, CFX_Int32Array* startGuardRange, int32_t hints, - int32_t& e); - CFX_ByteString Decode(CBC_BinaryBitmap* image, int32_t& e); - CFX_ByteString Decode(CBC_BinaryBitmap* image, int32_t hints, int32_t& e); + int32_t& e) override; + + // CBC_OneDReader + CFX_ByteString Decode(CBC_BinaryBitmap* image, int32_t& e) override; + CFX_ByteString Decode(CBC_BinaryBitmap* image, + int32_t hints, + int32_t& e) override; protected: int32_t DecodeMiddle(CBC_CommonBitArray* row, CFX_Int32Array* startRange, CFX_ByteString& resultString, - int32_t& e); + int32_t& e) override; CFX_ByteString MaybeReturnResult(CFX_ByteString& result, int32_t& e); private: |