diff options
author | Tom Sepez <tsepez@chromium.org> | 2017-01-31 13:02:10 -0800 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-01-31 22:52:16 +0000 |
commit | c8017b2581b7ade6b05ba086eb7221465414173f (patch) | |
tree | f606dadefe9d6e27e7782bd9c33e2498810a7b2f /xfa/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp | |
parent | 00d4064e5414fc0845e354b50c7f1a8323449268 (diff) | |
download | pdfium-c8017b2581b7ade6b05ba086eb7221465414173f.tar.xz |
Remove BC_EXCEPTION_CHECK macroschromium/2999
These obfuscate control flow and save very few lines.
Mechanical change (mostly), sed + clang-format and adding a
few missing semicolons.
Change-Id: If8ae06c23edea8c455c79eab589fee5142dc3409
Reviewed-on: https://pdfium-review.googlesource.com/2472
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp')
-rw-r--r-- | xfa/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/xfa/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp b/xfa/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp index 8342b9b6db..acc0cc9459 100644 --- a/xfa/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp +++ b/xfa/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp @@ -128,7 +128,8 @@ bool CBC_QRCoderMaskUtil::GetDataMaskBit(int32_t maskPattern, int32_t& e) { if (!CBC_QRCoder::IsValidMaskPattern(maskPattern)) { e = (BCExceptionInvalidateMaskPattern); - BC_EXCEPTION_CHECK_ReturnValue(e, false); + if (e != BCExceptionNO) + return false; } int32_t intermediate = 0, temp = 0; switch (maskPattern) { @@ -161,7 +162,8 @@ bool CBC_QRCoderMaskUtil::GetDataMaskBit(int32_t maskPattern, break; default: { e = BCExceptionInvalidateMaskPattern; - BC_EXCEPTION_CHECK_ReturnValue(e, false); + if (e != BCExceptionNO) + return false; } } return intermediate == 0; |