summaryrefslogtreecommitdiff
path: root/xfa/fxfa/app/xfa_textlayout.cpp
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-04-19 14:11:59 -0700
committerCommit bot <commit-bot@chromium.org>2016-04-19 14:11:59 -0700
commit4d31d0c653cf66f72bdef7cebbf7cff45d33f6c6 (patch)
tree63bd0f15c758b60a5ce577ac1a1f8bb24cb387c8 /xfa/fxfa/app/xfa_textlayout.cpp
parente3bbfa29b9d38dbbb77c12692eba3c40a7fb2870 (diff)
downloadpdfium-4d31d0c653cf66f72bdef7cebbf7cff45d33f6c6.tar.xz
Remove a few more char* members from structs/classes.
This is a result of looking for the anti-paterns /char\*\sm_/ and /m_.*=.*\.c_str/ which indicate that a class may be using the contents of a string without extending the lifetime of the underlying storage. Along the way, change to uint8_t in fx_dib; this is unrelated but avoids grep hits (it is binary, not chars anyways). Also remove two string operators that make it easy to assign in a manner that does not extend contents lifetime. Review URL: https://codereview.chromium.org/1902953002
Diffstat (limited to 'xfa/fxfa/app/xfa_textlayout.cpp')
-rw-r--r--xfa/fxfa/app/xfa_textlayout.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/xfa/fxfa/app/xfa_textlayout.cpp b/xfa/fxfa/app/xfa_textlayout.cpp
index 80342a383e..532d6f54ce 100644
--- a/xfa/fxfa/app/xfa_textlayout.cpp
+++ b/xfa/fxfa/app/xfa_textlayout.cpp
@@ -37,8 +37,8 @@ void CXFA_CSSTagProvider::GetNextAttribute(FX_POSITION& pos,
CFX_WideString* pName = NULL;
CFX_WideString* pValue = NULL;
m_Attributes.GetNextAssoc(pos, (void*&)pName, (void*&)pValue);
- wsAttr = *pName;
- wsValue = *pValue;
+ wsAttr = pName->AsStringC();
+ wsValue = pValue->AsStringC();
}
void CXFA_CSSTagProvider::SetAttribute(const CFX_WideString& wsAttr,
const CFX_WideString& wsValue) {