diff options
| author | dsinclair <dsinclair@chromium.org> | 2016-11-15 12:00:41 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-11-15 12:00:41 -0800 |
| commit | 05b9a317d66c29f740e4b0e89ea87143a11d61fc (patch) | |
| tree | 642bca12314f6730071c9d6fd0d871e73f9b0b29 /xfa/fxfa/app | |
| parent | 70c4afd5c3c5c44cd24f814423a23a6ef05bba02 (diff) | |
| download | pdfium-05b9a317d66c29f740e4b0e89ea87143a11d61fc.tar.xz | |
Cleaning methods and visibility in cfwl_* files.
First pass at cleaning up visibility, return values and const'ness of
cfwl_* class.
Review-Url: https://codereview.chromium.org/2501743002
Diffstat (limited to 'xfa/fxfa/app')
| -rw-r--r-- | xfa/fxfa/app/xfa_ffapp.cpp | 2 | ||||
| -rw-r--r-- | xfa/fxfa/app/xfa_fwladapter.cpp | 9 | ||||
| -rw-r--r-- | xfa/fxfa/app/xfa_fwladapter.h | 2 |
3 files changed, 6 insertions, 7 deletions
diff --git a/xfa/fxfa/app/xfa_ffapp.cpp b/xfa/fxfa/app/xfa_ffapp.cpp index ccdd6427ef..b38e59090e 100644 --- a/xfa/fxfa/app/xfa_ffapp.cpp +++ b/xfa/fxfa/app/xfa_ffapp.cpp @@ -131,7 +131,7 @@ CXFA_FWLTheme* CXFA_FFApp::GetFWLTheme() { } CXFA_FWLAdapterWidgetMgr* CXFA_FFApp::GetWidgetMgr( - CFWL_WidgetMgrDelegate* pDelegate) { + IFWL_WidgetMgrDelegate* pDelegate) { if (!m_pAdapterWidgetMgr) { m_pAdapterWidgetMgr.reset(new CXFA_FWLAdapterWidgetMgr); pDelegate->OnSetCapability(FWL_WGTMGR_DisableThread | diff --git a/xfa/fxfa/app/xfa_fwladapter.cpp b/xfa/fxfa/app/xfa_fwladapter.cpp index d827ad101f..ba38f853a6 100644 --- a/xfa/fxfa/app/xfa_fwladapter.cpp +++ b/xfa/fxfa/app/xfa_fwladapter.cpp @@ -13,18 +13,17 @@ CXFA_FWLAdapterWidgetMgr::CXFA_FWLAdapterWidgetMgr() {} CXFA_FWLAdapterWidgetMgr::~CXFA_FWLAdapterWidgetMgr() {} -FWL_Error CXFA_FWLAdapterWidgetMgr::RepaintWidget(IFWL_Widget* pWidget, - const CFX_RectF* pRect) { +void CXFA_FWLAdapterWidgetMgr::RepaintWidget(IFWL_Widget* pWidget, + const CFX_RectF* pRect) { if (!pWidget) - return FWL_Error::Indefinite; + return; CXFA_FFWidget* pFFWidget = static_cast<CXFA_FFWidget*>(pWidget->GetLayoutItem()); if (!pFFWidget) - return FWL_Error::Indefinite; + return; pFFWidget->AddInvalidateRect(nullptr); - return FWL_Error::Succeeded; } bool CXFA_FWLAdapterWidgetMgr::GetPopupPos(IFWL_Widget* pWidget, diff --git a/xfa/fxfa/app/xfa_fwladapter.h b/xfa/fxfa/app/xfa_fwladapter.h index cb10399ae7..489d8709ac 100644 --- a/xfa/fxfa/app/xfa_fwladapter.h +++ b/xfa/fxfa/app/xfa_fwladapter.h @@ -18,7 +18,7 @@ class CXFA_FWLAdapterWidgetMgr { CXFA_FWLAdapterWidgetMgr(); ~CXFA_FWLAdapterWidgetMgr(); - FWL_Error RepaintWidget(IFWL_Widget* pWidget, const CFX_RectF* pRect); + void RepaintWidget(IFWL_Widget* pWidget, const CFX_RectF* pRect); bool GetPopupPos(IFWL_Widget* pWidget, FX_FLOAT fMinHeight, FX_FLOAT fMaxHeight, |