diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2016-11-21 13:50:32 -0500 |
|---|---|---|
| committer | dan sinclair <dsinclair@chromium.org> | 2016-11-21 18:51:10 +0000 |
| commit | 85c8e7f788512ce5b5b43cd816e8091b57c3d5e7 (patch) | |
| tree | e727d747684b9db2632ef250b55046cfce2b55a3 /xfa/fxfa/app | |
| parent | 7daa6fb286d1b5d65f99521f3314083e86d93e3f (diff) | |
| download | pdfium-85c8e7f788512ce5b5b43cd816e8091b57c3d5e7.tar.xz | |
Fixup lint flags.
The -build/include setting was masking out build/include_what_you_use. This CL
restores them, fixes any build errors, and adds NOLINT as needed. As well,
the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd.
lint cleanups
Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f
Reviewed-on: https://pdfium-review.googlesource.com/2030
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fxfa/app')
| -rw-r--r-- | xfa/fxfa/app/xfa_ffapp.cpp | 2 | ||||
| -rw-r--r-- | xfa/fxfa/app/xfa_ffapp_unittest.cpp | 1 | ||||
| -rw-r--r-- | xfa/fxfa/app/xfa_ffdoc.cpp | 2 | ||||
| -rw-r--r-- | xfa/fxfa/app/xfa_ffnotify.h | 2 | ||||
| -rw-r--r-- | xfa/fxfa/app/xfa_ffwidget.cpp | 1 | ||||
| -rw-r--r-- | xfa/fxfa/app/xfa_fwltheme.h | 2 |
6 files changed, 8 insertions, 2 deletions
diff --git a/xfa/fxfa/app/xfa_ffapp.cpp b/xfa/fxfa/app/xfa_ffapp.cpp index d65a611eb9..3f013487f2 100644 --- a/xfa/fxfa/app/xfa_ffapp.cpp +++ b/xfa/fxfa/app/xfa_ffapp.cpp @@ -7,7 +7,9 @@ #include "xfa/fxfa/xfa_ffapp.h" #include <algorithm> +#include <memory> #include <utility> +#include <vector> #include "xfa/fgas/font/cfgas_fontmgr.h" #include "xfa/fwl/core/cfwl_widgetmgr.h" diff --git a/xfa/fxfa/app/xfa_ffapp_unittest.cpp b/xfa/fxfa/app/xfa_ffapp_unittest.cpp index 7e1b9d7237..10c0545fbb 100644 --- a/xfa/fxfa/app/xfa_ffapp_unittest.cpp +++ b/xfa/fxfa/app/xfa_ffapp_unittest.cpp @@ -5,6 +5,7 @@ #include "xfa/fxfa/xfa_ffapp.h" #include <memory> +#include <vector> #include "core/fpdfapi/parser/cpdf_dictionary.h" #include "core/fpdfapi/parser/cpdf_stream.h" diff --git a/xfa/fxfa/app/xfa_ffdoc.cpp b/xfa/fxfa/app/xfa_ffdoc.cpp index 5439b1fe47..3d1ead5069 100644 --- a/xfa/fxfa/app/xfa_ffdoc.cpp +++ b/xfa/fxfa/app/xfa_ffdoc.cpp @@ -7,6 +7,8 @@ #include "xfa/fxfa/xfa_ffdoc.h" #include <algorithm> +#include <memory> +#include <vector> #include "core/fpdfapi/parser/cpdf_array.h" #include "core/fpdfapi/parser/cpdf_document.h" diff --git a/xfa/fxfa/app/xfa_ffnotify.h b/xfa/fxfa/app/xfa_ffnotify.h index d9530a895e..1bfaffec89 100644 --- a/xfa/fxfa/app/xfa_ffnotify.h +++ b/xfa/fxfa/app/xfa_ffnotify.h @@ -14,7 +14,7 @@ class CXFA_FFWidgetHandler; class CXFA_FFNotify { public: - CXFA_FFNotify(CXFA_FFDoc* pDoc); + explicit CXFA_FFNotify(CXFA_FFDoc* pDoc); ~CXFA_FFNotify(); void OnPageEvent(CXFA_ContainerLayoutItem* pSender, uint32_t dwEvent); diff --git a/xfa/fxfa/app/xfa_ffwidget.cpp b/xfa/fxfa/app/xfa_ffwidget.cpp index 07ba16cd80..afc2a05f6e 100644 --- a/xfa/fxfa/app/xfa_ffwidget.cpp +++ b/xfa/fxfa/app/xfa_ffwidget.cpp @@ -8,6 +8,7 @@ #include <algorithm> #include <memory> +#include <vector> #include "core/fpdfapi/page/cpdf_pageobjectholder.h" #include "core/fxcodec/codec/ccodec_progressivedecoder.h" diff --git a/xfa/fxfa/app/xfa_fwltheme.h b/xfa/fxfa/app/xfa_fwltheme.h index 41ddc74c34..630653236f 100644 --- a/xfa/fxfa/app/xfa_fwltheme.h +++ b/xfa/fxfa/app/xfa_fwltheme.h @@ -26,7 +26,7 @@ class CXFA_FWLTheme final : public IFWL_ThemeProvider { public: - CXFA_FWLTheme(CXFA_FFApp* pApp); + explicit CXFA_FWLTheme(CXFA_FFApp* pApp); ~CXFA_FWLTheme() override; // IFWL_ThemeProvider: |