Cleanup some xfa/fxfa code.

This CL moves the .h files to have names corresponding to the contained
classes. The .cpp files are moved alongside the .h files. Any extra
classes in the .h files have been split into their own files.

Change-Id: I14b4efc02417f0df946500e87b6c502e77020db8
Reviewed-on: https://pdfium-review.googlesource.com/3160
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

1 files changed, 87 insertions, 0 deletions

diff --git a/xfa/fxfa/cxfa_ffapp_unitest.cpp b/xfa/fxfa/cxfa_ffapp_unitest.cpp
new file mode 100644
index 0000000000..e8accdfeb2
--- /dev/null
+++ b/xfa/fxfa/cxfa_ffapp_unitest.cpp
@@ -0,0 +1,87 @@
+// Copyright 2016 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "xfa/fxfa/cxfa_ffapp.h"
+
+#include <memory>
+#include <vector>
+
+#include "core/fpdfapi/parser/cpdf_dictionary.h"
+#include "core/fpdfapi/parser/cpdf_stream.h"
+#include "core/fxcrt/fx_memory.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/base/ptr_util.h"
+
+TEST(CXFAFileRead, NoStreams) {
+  std::vector<CPDF_Stream*> streams;
+  CFX_RetainPtr<IFX_SeekableReadStream> fileread =
+      MakeSeekableReadStream(streams);
+
+  uint8_t output_buffer[16];
+  memset(output_buffer, 0xbd, sizeof(output_buffer));
+  EXPECT_FALSE(fileread->ReadBlock(output_buffer, 0, 0));
+  EXPECT_EQ(0xbd, output_buffer[0]);
+}
+
+TEST(CXFAFileRead, EmptyStreams) {
+  std::vector<CPDF_Stream*> streams;
+  auto stream1 = pdfium::MakeUnique<CPDF_Stream>();
+  streams.push_back(stream1.get());
+  CFX_RetainPtr<IFX_SeekableReadStream> fileread =
+      MakeSeekableReadStream(streams);
+
+  uint8_t output_buffer[16];
+  memset(output_buffer, 0xbd, sizeof(output_buffer));
+  EXPECT_FALSE(fileread->ReadBlock(output_buffer, 0, 0));
+  EXPECT_EQ(0xbd, output_buffer[0]);
+}
+
+TEST(CXFAFileRead, NormalStreams) {
+  std::vector<CPDF_Stream*> streams;
+  auto stream1 = pdfium::MakeUnique<CPDF_Stream>();
+  auto stream2 = pdfium::MakeUnique<CPDF_Stream>();
+  auto stream3 = pdfium::MakeUnique<CPDF_Stream>();
+
+  // 16 chars total.
+  stream1->InitStream(reinterpret_cast<const uint8_t*>("one t"), 5,
+                      pdfium::MakeUnique<CPDF_Dictionary>());
+  stream2->InitStream(reinterpret_cast<const uint8_t*>("wo "), 3,
+                      pdfium::MakeUnique<CPDF_Dictionary>());
+  stream3->InitStream(reinterpret_cast<const uint8_t*>("three!!!"), 8,
+                      pdfium::MakeUnique<CPDF_Dictionary>());
+
+  streams.push_back(stream1.get());
+  streams.push_back(stream2.get());
+  streams.push_back(stream3.get());
+  CFX_RetainPtr<IFX_SeekableReadStream> fileread =
+      MakeSeekableReadStream(streams);
+
+  uint8_t output_buffer[16];
+  memset(output_buffer, 0xbd, sizeof(output_buffer));
+  EXPECT_TRUE(fileread->ReadBlock(output_buffer, 0, 0));
+  EXPECT_EQ(0xbd, output_buffer[0]);
+
+  memset(output_buffer, 0xbd, sizeof(output_buffer));
+  EXPECT_TRUE(fileread->ReadBlock(output_buffer, 1, 0));
+  EXPECT_EQ(0xbd, output_buffer[0]);
+
+  memset(output_buffer, 0xbd, sizeof(output_buffer));
+  EXPECT_TRUE(fileread->ReadBlock(output_buffer, 0, 1));
+  EXPECT_EQ(0, memcmp(output_buffer, "o", 1));
+  EXPECT_EQ(0xbd, output_buffer[1]);
+
+  memset(output_buffer, 0xbd, sizeof(output_buffer));
+  EXPECT_TRUE(fileread->ReadBlock(output_buffer, 0, sizeof(output_buffer)));
+  EXPECT_EQ(0, memcmp(output_buffer, "one two three!!!", 16));
+
+  memset(output_buffer, 0xbd, sizeof(output_buffer));
+  EXPECT_TRUE(fileread->ReadBlock(output_buffer, 2, 10));
+  EXPECT_EQ(0, memcmp(output_buffer, "e two thre", 10));
+  EXPECT_EQ(0xbd, output_buffer[11]);
+
+  memset(output_buffer, 0xbd, sizeof(output_buffer));
+  EXPECT_FALSE(fileread->ReadBlock(output_buffer, 1, sizeof(output_buffer)));
+  EXPECT_EQ(0, memcmp(output_buffer, "ne two three!!!", 15));
+  EXPECT_EQ(0xbd, output_buffer[15]);
+}