diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-20 21:19:13 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-20 21:19:13 +0000 |
| commit | 2501ae2474c1f097a06634d647de2eb3fb730864 (patch) | |
| tree | 3ac7d386a3e73f3c848c203c3f0e61af9d284c1f /xfa/fxfa/cxfa_ffdatetimeedit.cpp | |
| parent | 89453e92d5d0b7aaf9e0c3890a90a21adc94a0ce (diff) | |
| download | pdfium-2501ae2474c1f097a06634d647de2eb3fb730864.tar.xz | |
Remove CXFA_DataData operator bool override
This CL removes CXFA_DataData::operator bool in favour of an explicit
HasValidNode method. This makes the call sites a lot clearer.
Change-Id: I6fae14fdeec4674ca7916e21b9e5703070fc3069
Reviewed-on: https://pdfium-review.googlesource.com/18830
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'xfa/fxfa/cxfa_ffdatetimeedit.cpp')
| -rw-r--r-- | xfa/fxfa/cxfa_ffdatetimeedit.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/xfa/fxfa/cxfa_ffdatetimeedit.cpp b/xfa/fxfa/cxfa_ffdatetimeedit.cpp index 7958162a89..1b2f6e3221 100644 --- a/xfa/fxfa/cxfa_ffdatetimeedit.cpp +++ b/xfa/fxfa/cxfa_ffdatetimeedit.cpp @@ -50,7 +50,8 @@ bool CXFA_FFDateTimeEdit::LoadWidget() { WideString wsText; m_pDataAcc->GetValue(wsText, XFA_VALUEPICTURE_Display); pWidget->SetEditText(wsText); - if (CXFA_ValueData valueData = m_pDataAcc->GetFormValueData()) { + CXFA_ValueData valueData = m_pDataAcc->GetFormValueData(); + if (valueData.HasValidNode()) { switch (valueData.GetChildValueClassID()) { case XFA_Element::Date: { if (!wsText.IsEmpty()) { @@ -97,7 +98,7 @@ void CXFA_FFDateTimeEdit::UpdateWidgetProperty() { uint32_t CXFA_FFDateTimeEdit::GetAlignment() { CXFA_ParaData paraData = m_pDataAcc->GetParaData(); - if (!paraData) + if (!paraData.HasValidNode()) return 0; uint32_t dwExtendedStyle = 0; |