Cleanup CJX_Node::GetAttribute

This CL renames GetAttribute to TryAttribute and changes to return a
pdfium::Optional instead of a boolean with an out parameter.
GetAttribute is then added to call TryAttribute to mirror the other
methods in the file.
Change-Id: I875dac120776af7c53fe069e4dd36e5486838447
Reviewed-on: https://pdfium-review.googlesource.com/18514
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

1 files changed, 4 insertions, 5 deletions

diff --git a/xfa/fxfa/cxfa_ffpageview.cpp b/xfa/fxfa/cxfa_ffpageview.cpp
index 3c88a121da..26bdc26acd 100644
--- a/xfa/fxfa/cxfa_ffpageview.cpp
+++ b/xfa/fxfa/cxfa_ffpageview.cpp
@@ -314,11 +314,10 @@ CXFA_FFWidget* CXFA_FFTabOrderPageWidgetIterator::GetTraverseWidget(
     CXFA_Node* pTraverse =
         pTraversal->GetChild(0, XFA_Element::Traverse, false);
     if (pTraverse) {
-      WideString wsTraverseWidgetName;
-      if (pTraverse->JSNode()->GetAttribute(XFA_Attribute::Ref,
-                                            wsTraverseWidgetName, true)) {
-        return FindWidgetByName(wsTraverseWidgetName, pWidget);
-      }
+      pdfium::Optional<WideString> traverseWidgetName =
+          pTraverse->JSNode()->TryAttribute(XFA_Attribute::Ref, true);
+      if (traverseWidgetName)
+        return FindWidgetByName(*traverseWidgetName, pWidget);
     }
   }
   return nullptr;