summaryrefslogtreecommitdiff
path: root/xfa/fxfa/cxfa_fontmgr.cpp
diff options
context:
space:
mode:
authorHenrique Nakashima <hnakashima@chromium.org>2018-05-22 13:45:08 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-05-22 13:45:08 +0000
commita3ee6a0081ab16a2034b36d1d0f9b6907aec67d2 (patch)
treeaddf5f561a0c94a3f250833bb075bf10e2998d64 /xfa/fxfa/cxfa_fontmgr.cpp
parentb9d556e4282329c7bf6a0710ce6d742467e44e84 (diff)
downloadpdfium-a3ee6a0081ab16a2034b36d1d0f9b6907aec67d2.tar.xz
Fix spaces too wide in XFA Dropdown.
CFGAS_PDFFontMgr::GetCharWidth() is only used for spaces, for no good reason I could find. It's broken in this case too, returning a default value of 600 for any character. This CL removes this method and its only usage that led to finding this issue. Bug: pdfium:1083 Change-Id: I954de45101715b5af05169612fb5eca1b1a170b4 Reviewed-on: https://pdfium-review.googlesource.com/32740 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa/cxfa_fontmgr.cpp')
-rw-r--r--xfa/fxfa/cxfa_fontmgr.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/xfa/fxfa/cxfa_fontmgr.cpp b/xfa/fxfa/cxfa_fontmgr.cpp
index c35b10c9bc..8bacf07742 100644
--- a/xfa/fxfa/cxfa_fontmgr.cpp
+++ b/xfa/fxfa/cxfa_fontmgr.cpp
@@ -74,10 +74,9 @@ RetainPtr<CFGAS_GEFont> CXFA_FontMgr::GetFont(
}
if (pFont) {
- if (pPDFFont) {
+ if (pPDFFont)
pMgr->SetFont(pFont, pPDFFont);
- pFont->SetFontProvider(pMgr);
- }
+
m_FontMap[bsKey] = pFont;
}
return pFont;