diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-07-26 19:34:26 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-07-26 19:34:26 +0000 |
| commit | c9171e16d9d4477501d326d8d456fdc03e0f832e (patch) | |
| tree | 89a91af4803e820b2e7f8c6e9901915c3415d72c /xfa/fxfa/cxfa_textlayout.cpp | |
| parent | ea360af9048e7083107f9e27f8967351df241f70 (diff) | |
| download | pdfium-c9171e16d9d4477501d326d8d456fdc03e0f832e.tar.xz | |
Use moar ToXMLElement() in place of static_cast<>.
Introduces checks in a few new places, but mainly just consolidates
checking/casting logic.
Change-Id: I634a03060d254db099972c6978249992367e146c
Reviewed-on: https://pdfium-review.googlesource.com/38900
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'xfa/fxfa/cxfa_textlayout.cpp')
| -rw-r--r-- | xfa/fxfa/cxfa_textlayout.cpp | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/xfa/fxfa/cxfa_textlayout.cpp b/xfa/fxfa/cxfa_textlayout.cpp index 32a1b393a6..8bf955bd32 100644 --- a/xfa/fxfa/cxfa_textlayout.cpp +++ b/xfa/fxfa/cxfa_textlayout.cpp @@ -77,19 +77,17 @@ CFX_XMLNode* CXFA_TextLayout::GetXMLContainerNode() { if (!pXMLRoot) return nullptr; - CFX_XMLNode* pXMLContainer = nullptr; for (CFX_XMLNode* pXMLChild = pXMLRoot->GetFirstChild(); pXMLChild; pXMLChild = pXMLChild->GetNextSibling()) { - if (pXMLChild->GetType() == FX_XMLNODE_Element) { - CFX_XMLElement* pXMLElement = static_cast<CFX_XMLElement*>(pXMLChild); - WideString wsTag = pXMLElement->GetLocalTagName(); - if (wsTag == L"body" || wsTag == L"html") { - pXMLContainer = pXMLChild; - break; - } - } + CFX_XMLElement* pXMLElement = ToXMLElement(pXMLChild); + if (!pXMLElement) + continue; + WideString wsTag = pXMLElement->GetLocalTagName(); + if (wsTag == L"body" || wsTag == L"html") + return pXMLChild; } - return pXMLContainer; + + return nullptr; } std::unique_ptr<CFX_RTFBreak> CXFA_TextLayout::CreateBreak(bool bDefault) { |