diff options
| author | Lei Zhang <thestig@chromium.org> | 2018-08-21 20:52:02 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-08-21 20:52:02 +0000 |
| commit | 7af775a00379e84c0da1ab81695583eb7daaec3a (patch) | |
| tree | a302accbd2463976903b102f01db0c588b5e1859 /xfa/fxfa/cxfa_textparser.cpp | |
| parent | e4110926f26fcd9a906b2ceb722a4f3b50461130 (diff) | |
| download | pdfium-7af775a00379e84c0da1ab81695583eb7daaec3a.tar.xz | |
Change GetEmbbedObj() to return an Optional<WideString>.
Change "EmbbedObj" to "EmbeddedObj".
Change-Id: Ia6a8ec45b4563b3ec64b91a10e087dbf32a8d8db
Reviewed-on: https://pdfium-review.googlesource.com/40751
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'xfa/fxfa/cxfa_textparser.cpp')
| -rw-r--r-- | xfa/fxfa/cxfa_textparser.cpp | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/xfa/fxfa/cxfa_textparser.cpp b/xfa/fxfa/cxfa_textparser.cpp index c60b774051..0d1c52fab7 100644 --- a/xfa/fxfa/cxfa_textparser.cpp +++ b/xfa/fxfa/cxfa_textparser.cpp @@ -495,20 +495,19 @@ float CXFA_TextParser::GetLineHeight(CXFA_TextProvider* pTextProvider, return fLineHeight; } -bool CXFA_TextParser::GetEmbbedObj(CXFA_TextProvider* pTextProvider, - CFX_XMLNode* pXMLNode, - WideString& wsValue) { - wsValue.clear(); +Optional<WideString> CXFA_TextParser::GetEmbeddedObj( + CXFA_TextProvider* pTextProvider, + CFX_XMLNode* pXMLNode) { if (!pXMLNode) - return false; + return {}; CFX_XMLElement* pElement = ToXMLElement(pXMLNode); if (!pElement) - return false; + return {}; WideString wsAttr = pElement->GetAttribute(L"xfa:embed"); if (wsAttr.IsEmpty()) - return false; + return {}; if (wsAttr[0] == L'#') wsAttr.Delete(0); @@ -521,7 +520,7 @@ bool CXFA_TextParser::GetEmbbedObj(CXFA_TextProvider* pTextProvider, bool bURI = (ws == L"uri"); if (!bURI && ws != L"som") - return false; + return {}; ws = pElement->GetAttribute(L"xfa:embedMode"); if (ws.IsEmpty()) @@ -531,9 +530,9 @@ bool CXFA_TextParser::GetEmbbedObj(CXFA_TextProvider* pTextProvider, bool bRaw = (ws == L"raw"); if (!bRaw && ws != L"formatted") - return false; + return {}; - return pTextProvider->GetEmbbedObj(bURI, bRaw, wsAttr, wsValue); + return pTextProvider->GetEmbeddedObj(bURI, bRaw, wsAttr); } CXFA_TextParseContext* CXFA_TextParser::GetParseContextFromMap( |