diff options
| author | dan sinclair <dsinclair@chromium.org> | 2018-02-19 18:18:38 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-19 18:18:38 +0000 |
| commit | 00961a731b4811f84b5610d0b752f2f2b610f8ff (patch) | |
| tree | 3eeba992b11a7ecbfb89fc7009acba4da2d42f14 /xfa/fxfa/fm2js/cxfa_fmsimpleexpression.cpp | |
| parent | d276a52cd5061e0d4ee4aa79b8e89bbeb0a89da3 (diff) | |
| download | pdfium-00961a731b4811f84b5610d0b752f2f2b610f8ff.tar.xz | |
Remove base class ToJavaScript methods in FormCalc
This CL removes the Loop base class as it adds no functionality. Other
base classes have had their ToJavaScript methods set as pure virtual and
their constructors made protected.
Change-Id: I5c77b8734d23c576dd52db7f72396ecdf2f7bd22
Reviewed-on: https://pdfium-review.googlesource.com/27270
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa/fm2js/cxfa_fmsimpleexpression.cpp')
| -rw-r--r-- | xfa/fxfa/fm2js/cxfa_fmsimpleexpression.cpp | 20 |
1 files changed, 2 insertions, 18 deletions
diff --git a/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.cpp b/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.cpp index 8354072b4d..ec61511284 100644 --- a/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.cpp +++ b/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.cpp @@ -74,11 +74,6 @@ const XFA_FMSOMMethod gs_FMSomMethods[] = { CXFA_FMSimpleExpression::CXFA_FMSimpleExpression(uint32_t line, XFA_FM_TOKEN op) : m_line(line), m_op(op) {} -bool CXFA_FMSimpleExpression::ToJavaScript(CFX_WideTextBuf& js, - ReturnType type) { - CXFA_FMToJavaScriptDepth depthManager; - return !CXFA_IsTooBig(js) && depthManager.IsWithinMaxDepth(); -} XFA_FM_TOKEN CXFA_FMSimpleExpression::GetOperatorToken() const { return m_op; } @@ -195,13 +190,7 @@ CXFA_FMUnaryExpression::CXFA_FMUnaryExpression( std::unique_ptr<CXFA_FMSimpleExpression> pExp) : CXFA_FMSimpleExpression(line, op), m_pExp(std::move(pExp)) {} -CXFA_FMUnaryExpression::~CXFA_FMUnaryExpression() {} - -bool CXFA_FMUnaryExpression::ToJavaScript(CFX_WideTextBuf& js, - ReturnType type) { - CXFA_FMToJavaScriptDepth depthManager; - return !CXFA_IsTooBig(js) && depthManager.IsWithinMaxDepth(); -} +CXFA_FMUnaryExpression::~CXFA_FMUnaryExpression() = default; CXFA_FMBinExpression::CXFA_FMBinExpression( uint32_t line, @@ -212,12 +201,7 @@ CXFA_FMBinExpression::CXFA_FMBinExpression( m_pExp1(std::move(pExp1)), m_pExp2(std::move(pExp2)) {} -CXFA_FMBinExpression::~CXFA_FMBinExpression() {} - -bool CXFA_FMBinExpression::ToJavaScript(CFX_WideTextBuf& js, ReturnType type) { - CXFA_FMToJavaScriptDepth depthManager; - return !CXFA_IsTooBig(js) && depthManager.IsWithinMaxDepth(); -} +CXFA_FMBinExpression::~CXFA_FMBinExpression() = default; CXFA_FMAssignExpression::CXFA_FMAssignExpression( uint32_t line, |