diff options
author | dan sinclair <dsinclair@chromium.org> | 2018-02-19 18:18:38 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-19 18:18:38 +0000 |
commit | 00961a731b4811f84b5610d0b752f2f2b610f8ff (patch) | |
tree | 3eeba992b11a7ecbfb89fc7009acba4da2d42f14 /xfa/fxfa/fm2js/cxfa_fmsimpleexpression_unittest.cpp | |
parent | d276a52cd5061e0d4ee4aa79b8e89bbeb0a89da3 (diff) | |
download | pdfium-00961a731b4811f84b5610d0b752f2f2b610f8ff.tar.xz |
Remove base class ToJavaScript methods in FormCalc
This CL removes the Loop base class as it adds no functionality. Other
base classes have had their ToJavaScript methods set as pure virtual and
their constructors made protected.
Change-Id: I5c77b8734d23c576dd52db7f72396ecdf2f7bd22
Reviewed-on: https://pdfium-review.googlesource.com/27270
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa/fm2js/cxfa_fmsimpleexpression_unittest.cpp')
-rw-r--r-- | xfa/fxfa/fm2js/cxfa_fmsimpleexpression_unittest.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/xfa/fxfa/fm2js/cxfa_fmsimpleexpression_unittest.cpp b/xfa/fxfa/fm2js/cxfa_fmsimpleexpression_unittest.cpp index e97df41ad7..168de84db4 100644 --- a/xfa/fxfa/fm2js/cxfa_fmsimpleexpression_unittest.cpp +++ b/xfa/fxfa/fm2js/cxfa_fmsimpleexpression_unittest.cpp @@ -21,7 +21,7 @@ TEST(FMCallExpressionTest, more_than_32_arguments) { std::vector<std::unique_ptr<CXFA_FMSimpleExpression>> args; for (size_t i = 0; i < 50; i++) - args.push_back(pdfium::MakeUnique<CXFA_FMSimpleExpression>(0, TOKnan)); + args.push_back(pdfium::MakeUnique<CXFA_FMNullExpression>(0)); CXFA_FMToJavaScriptDepth::Reset(); CXFA_FMCallExpression callExp(0, std::move(exp), std::move(args), true); @@ -37,9 +37,9 @@ TEST(FMCallExpressionTest, more_than_32_arguments) { result += L"pfm_rt.get_"; // Object positions for sign() method. if (i == 0 || i == 5 || i == 6) - result += L"jsobj()"; + result += L"jsobj(null)"; else - result += L"val()"; + result += L"val(null)"; } result += L")"; |