diff options
| author | tsepez <tsepez@chromium.org> | 2016-05-16 13:21:03 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-05-16 13:21:03 -0700 |
| commit | cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9 (patch) | |
| tree | fda580a573f97d15c9484c57ebf8fae66342ab83 /xfa/fxfa/include/fxfa.h | |
| parent | e699c66433049396e438d983a1837b9d4a4cf766 (diff) | |
| download | pdfium-cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9.tar.xz | |
Remove { delete this; } anti-pattern from IXFA_WidgetIterator
Review-Url: https://codereview.chromium.org/1976123003
Diffstat (limited to 'xfa/fxfa/include/fxfa.h')
| -rw-r--r-- | xfa/fxfa/include/fxfa.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/xfa/fxfa/include/fxfa.h b/xfa/fxfa/include/fxfa.h index 871ab71164..a173a0e299 100644 --- a/xfa/fxfa/include/fxfa.h +++ b/xfa/fxfa/include/fxfa.h @@ -541,7 +541,8 @@ class CXFA_RenderOptions { class IXFA_WidgetIterator { public: - virtual void Release() = 0; + virtual ~IXFA_WidgetIterator() {} + virtual void Reset() = 0; virtual CXFA_FFWidget* MoveToFirst() = 0; virtual CXFA_FFWidget* MoveToLast() = 0; @@ -549,9 +550,6 @@ class IXFA_WidgetIterator { virtual CXFA_FFWidget* MoveToPrevious() = 0; virtual CXFA_FFWidget* GetCurrentWidget() = 0; virtual FX_BOOL SetCurrentWidget(CXFA_FFWidget* hWidget) = 0; - - protected: - virtual ~IXFA_WidgetIterator() {} }; #endif // XFA_FXFA_INCLUDE_FXFA_H_ |