diff options
author | tsepez <tsepez@chromium.org> | 2016-05-16 13:21:03 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-05-16 13:21:03 -0700 |
commit | cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9 (patch) | |
tree | fda580a573f97d15c9484c57ebf8fae66342ab83 /xfa/fxfa/include/xfa_ffdocview.h | |
parent | e699c66433049396e438d983a1837b9d4a4cf766 (diff) | |
download | pdfium-cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9.tar.xz |
Remove { delete this; } anti-pattern from IXFA_WidgetIterator
Review-Url: https://codereview.chromium.org/1976123003
Diffstat (limited to 'xfa/fxfa/include/xfa_ffdocview.h')
-rw-r--r-- | xfa/fxfa/include/xfa_ffdocview.h | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/xfa/fxfa/include/xfa_ffdocview.h b/xfa/fxfa/include/xfa_ffdocview.h index 7f1c631da3..473b820def 100644 --- a/xfa/fxfa/include/xfa_ffdocview.h +++ b/xfa/fxfa/include/xfa_ffdocview.h @@ -125,20 +125,20 @@ class CXFA_FFDocView { int32_t m_iLock; friend class CXFA_FFNotify; }; + class CXFA_FFDocWidgetIterator : public IXFA_WidgetIterator { public: CXFA_FFDocWidgetIterator(CXFA_FFDocView* pDocView, CXFA_Node* pTravelRoot); - virtual ~CXFA_FFDocWidgetIterator(); - - virtual void Release() { delete this; } - - virtual void Reset(); - virtual CXFA_FFWidget* MoveToFirst(); - virtual CXFA_FFWidget* MoveToLast(); - virtual CXFA_FFWidget* MoveToNext(); - virtual CXFA_FFWidget* MoveToPrevious(); - virtual CXFA_FFWidget* GetCurrentWidget(); - virtual FX_BOOL SetCurrentWidget(CXFA_FFWidget* hWidget); + ~CXFA_FFDocWidgetIterator() override; + + // IXFA_WidgetIterator: + void Reset() override; + CXFA_FFWidget* MoveToFirst() override; + CXFA_FFWidget* MoveToLast() override; + CXFA_FFWidget* MoveToNext() override; + CXFA_FFWidget* MoveToPrevious() override; + CXFA_FFWidget* GetCurrentWidget() override; + FX_BOOL SetCurrentWidget(CXFA_FFWidget* hWidget) override; protected: CXFA_ContainerIterator m_ContentIterator; |