diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-30 21:29:11 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-30 21:29:11 +0000 |
| commit | c40c5aa2d7f1753dd382c35955deafdaca660020 (patch) | |
| tree | b427f5516046d40b8dd63f8c7a552fac0bf278ae /xfa/fxfa/parser/cxfa_dataexporter.cpp | |
| parent | 9daec60824d085db8c2f841fd389c725df1f8b0b (diff) | |
| download | pdfium-c40c5aa2d7f1753dd382c35955deafdaca660020.tar.xz | |
A CXFA_Node can only be in one packet
When a CXFA_Node is created it's created as part of a specific packet.
Previously the code would accept an XFA_XDPPACKET which was stored
internally. This had the potential to allow a node to exist in multiple
packets.
This CL changes the XFA_XDPPacket to the XFA_PacketType enum class and
cleans up a lot of uses to use the more specific packet type.
Change-Id: I7fc8c843bfa6bd32295ae58a26bcec311e43c4b0
Reviewed-on: https://pdfium-review.googlesource.com/20012
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser/cxfa_dataexporter.cpp')
| -rw-r--r-- | xfa/fxfa/parser/cxfa_dataexporter.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/xfa/fxfa/parser/cxfa_dataexporter.cpp b/xfa/fxfa/parser/cxfa_dataexporter.cpp index edb7e1e186..1113ba49b6 100644 --- a/xfa/fxfa/parser/cxfa_dataexporter.cpp +++ b/xfa/fxfa/parser/cxfa_dataexporter.cpp @@ -489,8 +489,8 @@ bool CXFA_DataExporter::Export( const char* pChecksum) { CFX_XMLDoc* pXMLDoc = m_pDocument->GetXMLDoc(); if (pNode->IsModelNode()) { - switch (pNode->GetPacketID()) { - case XFA_XDPPACKET_XDP: { + switch (pNode->GetPacketType()) { + case XFA_PacketType::Xdp: { pStream->WriteString( L"<xdp:xdp xmlns:xdp=\"http://ns.adobe.com/xdp/\">"); for (CXFA_Node* pChild = pNode->GetNodeItem(XFA_NODEITEM_FirstChild); @@ -500,7 +500,7 @@ bool CXFA_DataExporter::Export( pStream->WriteString(L"</xdp:xdp\n>"); break; } - case XFA_XDPPACKET_Datasets: { + case XFA_PacketType::Datasets: { CFX_XMLElement* pElement = static_cast<CFX_XMLElement*>(pNode->GetXMLMappingNode()); if (!pElement || pElement->GetType() != FX_XMLNODE_Element) @@ -512,11 +512,11 @@ bool CXFA_DataExporter::Export( pXMLDoc->SaveXMLNode(pStream, pElement); break; } - case XFA_XDPPACKET_Form: { + case XFA_PacketType::Form: { XFA_DataExporter_RegenerateFormFile(pNode, pStream, pChecksum); break; } - case XFA_XDPPACKET_Template: + case XFA_PacketType::Template: default: { CFX_XMLElement* pElement = static_cast<CFX_XMLElement*>(pNode->GetXMLMappingNode()); |