diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-04 01:49:37 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-04 01:49:37 +0000 |
| commit | c5d5729700a4d145cd298ec52f6f57b2d11aaafe (patch) | |
| tree | b9929296fc45c754d5f7748613cec15020664052 /xfa/fxfa/parser/cxfa_fill.cpp | |
| parent | cf705715c5311057933ac03b395d9ea75b6f0660 (diff) | |
| download | pdfium-c5d5729700a4d145cd298ec52f6f57b2d11aaafe.tar.xz | |
Remove default values from CXFA_Node::{CountChildren|GetChild}chromium/3259
This CL removes the default values and inlines into the call sites as
needed.
Change-Id: I554e9d5ac781003695f90522f9c6c3160653eb59
Reviewed-on: https://pdfium-review.googlesource.com/17572
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser/cxfa_fill.cpp')
| -rw-r--r-- | xfa/fxfa/parser/cxfa_fill.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/xfa/fxfa/parser/cxfa_fill.cpp b/xfa/fxfa/parser/cxfa_fill.cpp index 49e710bcaa..8430b254a8 100644 --- a/xfa/fxfa/parser/cxfa_fill.cpp +++ b/xfa/fxfa/parser/cxfa_fill.cpp @@ -30,7 +30,7 @@ void CXFA_Fill::SetColor(FX_ARGB color) { } FX_ARGB CXFA_Fill::GetColor(bool bText) { - if (CXFA_Node* pNode = m_pNode->GetChild(0, XFA_Element::Color)) { + if (CXFA_Node* pNode = m_pNode->GetChild(0, XFA_Element::Color, false)) { WideStringView wsColor; if (pNode->JSNode()->TryCData(XFA_ATTRIBUTE_Value, wsColor, false)) return CXFA_Data::ToColor(wsColor); @@ -55,7 +55,7 @@ XFA_Element CXFA_Fill::GetFillType() { int32_t CXFA_Fill::GetPattern(FX_ARGB& foreColor) { CXFA_Node* pNode = m_pNode->JSNode()->GetProperty(0, XFA_Element::Pattern, true); - if (CXFA_Node* pColor = pNode->GetChild(0, XFA_Element::Color)) { + if (CXFA_Node* pColor = pNode->GetChild(0, XFA_Element::Color, false)) { WideStringView wsColor; pColor->JSNode()->TryCData(XFA_ATTRIBUTE_Value, wsColor, false); foreColor = CXFA_Data::ToColor(wsColor); @@ -70,7 +70,7 @@ int32_t CXFA_Fill::GetStipple(FX_ARGB& stippleColor) { m_pNode->JSNode()->GetProperty(0, XFA_Element::Stipple, true); int32_t eAttr = 50; pNode->JSNode()->TryInteger(XFA_ATTRIBUTE_Rate, eAttr, true); - if (CXFA_Node* pColor = pNode->GetChild(0, XFA_Element::Color)) { + if (CXFA_Node* pColor = pNode->GetChild(0, XFA_Element::Color, false)) { WideStringView wsColor; pColor->JSNode()->TryCData(XFA_ATTRIBUTE_Value, wsColor, false); stippleColor = CXFA_Data::ToColor(wsColor); @@ -85,7 +85,7 @@ int32_t CXFA_Fill::GetLinear(FX_ARGB& endColor) { m_pNode->JSNode()->GetProperty(0, XFA_Element::Linear, true); XFA_ATTRIBUTEENUM eAttr = XFA_ATTRIBUTEENUM_ToRight; pNode->JSNode()->TryEnum(XFA_ATTRIBUTE_Type, eAttr, true); - if (CXFA_Node* pColor = pNode->GetChild(0, XFA_Element::Color)) { + if (CXFA_Node* pColor = pNode->GetChild(0, XFA_Element::Color, false)) { WideStringView wsColor; pColor->JSNode()->TryCData(XFA_ATTRIBUTE_Value, wsColor, false); endColor = CXFA_Data::ToColor(wsColor); @@ -100,7 +100,7 @@ int32_t CXFA_Fill::GetRadial(FX_ARGB& endColor) { m_pNode->JSNode()->GetProperty(0, XFA_Element::Radial, true); XFA_ATTRIBUTEENUM eAttr = XFA_ATTRIBUTEENUM_ToEdge; pNode->JSNode()->TryEnum(XFA_ATTRIBUTE_Type, eAttr, true); - if (CXFA_Node* pColor = pNode->GetChild(0, XFA_Element::Color)) { + if (CXFA_Node* pColor = pNode->GetChild(0, XFA_Element::Color, false)) { WideStringView wsColor; pColor->JSNode()->TryCData(XFA_ATTRIBUTE_Value, wsColor, false); endColor = CXFA_Data::ToColor(wsColor); |